Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4730)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h

Issue 250353003: Password bubble: refactor ManagePasswordsIconView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
index abe6de4dee3d859f622d3f225763da4d452dacb9..6906a9b72e13583797fa3c841a37edf6bc5c2103 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h
@@ -16,6 +16,8 @@ namespace content {
class WebContents;
}
+class ManagePasswordsIcon;
+
// Per-tab class to control the Omnibox password icon and bubble.
class ManagePasswordsBubbleUIController
: public content::WebContentsObserver,
@@ -51,15 +53,15 @@ class ManagePasswordsBubbleUIController
// the action off to the FormManager.
virtual void NeverSavePassword();
- // Called when the bubble is opened after the icon gets displayed. We change
- // the state to know that we do not need to pop up the bubble again.
- void OnBubbleShown();
-
// Open a new tab, pointing to the password manager settings page.
virtual void NavigateToPasswordManagerSettingsPage();
virtual const autofill::PasswordForm& PendingCredentials() const;
+ // Set the state of the Omnibox icon, and possibly show the associated bubble
+ // without user interaction.
+ virtual void UpdateIconAndBubbleState(ManagePasswordsIcon* icon);
+
bool manage_passwords_icon_to_be_shown() const {
return manage_passwords_icon_to_be_shown_;
}
@@ -72,10 +74,6 @@ class ManagePasswordsBubbleUIController
return manage_passwords_bubble_needs_showing_;
}
- void unset_manage_passwords_bubble_needs_showing() {
- manage_passwords_bubble_needs_showing_ = false;
- }
-
void unset_password_to_be_saved() {
password_to_be_saved_ = false;
}

Powered by Google App Engine
This is Rietveld 408576698