Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2503523002: [Interpreter] Add CallRuntime() for 5 arguments. (Closed)

Created:
4 years, 1 month ago by Franzi
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add CallRuntime() for 5 arguments. CodeAssembler::CallRuntime() with 5 arguments was declared but not implemented. BUG= Committed: https://crrev.com/c0291e122fccdde9afad22e892013791889e7505 Cr-Commit-Position: refs/heads/master@{#40973}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M src/compiler/code-assembler.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Franzi
CallRuntime() with 5 arguments was declared but never implemented (or used). I'll need it for ...
4 years, 1 month ago (2016-11-14 16:43:27 UTC) #6
Jarin
lgtm
4 years, 1 month ago (2016-11-14 17:12:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503523002/1
4 years, 1 month ago (2016-11-14 17:13:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 17:15:41 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:33:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0291e122fccdde9afad22e892013791889e7505
Cr-Commit-Position: refs/heads/master@{#40973}

Powered by Google App Engine
This is Rietveld 408576698