Hey, could you please take a look at the CL? Thanks, Hui
7 years, 2 months ago
(2013-09-27 15:20:09 UTC)
#1
Hey,
could you please take a look at the CL?
Thanks,
Hui
oshima
don't you want to put win7/win8 versions in different subdirectories? Also will there be 200p ...
7 years, 2 months ago
(2013-09-27 17:47:36 UTC)
#2
don't you want to put win7/win8 versions in different subdirectories?
Also will there be 200p versions? (+girard for Win high DPI support)
noms (inactive)
I'm not sure about the 200p versions: the existing buttons in default_100_percent/win don't seem to ...
7 years, 2 months ago
(2013-09-27 18:19:36 UTC)
#3
I'm not sure about the 200p versions: the existing buttons in
default_100_percent/win don't seem to have 200p counterparts. I will ask
sgabriel@ about what the plan is.
On 2013/09/27 17:47:36, oshima wrote:
> don't you want to put win7/win8 versions in different subdirectories?
>
> Also will there be 200p versions? (+girard for Win high DPI support)
guohui
On 2013/09/27 18:19:36, Monica Dinculescu wrote: > I'm not sure about the 200p versions: the ...
7 years, 2 months ago
(2013-10-01 12:14:02 UTC)
#4
On 2013/09/27 18:19:36, Monica Dinculescu wrote:
> I'm not sure about the 200p versions: the existing buttons in
> default_100_percent/win don't seem to have 200p counterparts. I will ask
> sgabriel@ about what the plan is.
>
>
> On 2013/09/27 17:47:36, oshima wrote:
> > don't you want to put win7/win8 versions in different subdirectories?
> >
> > Also will there be 200p versions? (+girard for Win high DPI support)
@monica, any update about 200p versions?
guohui
On 2013/10/01 12:14:02, guohui wrote: > On 2013/09/27 18:19:36, Monica Dinculescu wrote: > > I'm ...
7 years, 2 months ago
(2013-10-01 20:41:27 UTC)
#5
On 2013/10/01 12:14:02, guohui wrote:
> On 2013/09/27 18:19:36, Monica Dinculescu wrote:
> > I'm not sure about the 200p versions: the existing buttons in
> > default_100_percent/win don't seem to have 200p counterparts. I will ask
> > sgabriel@ about what the plan is.
> >
> >
> > On 2013/09/27 17:47:36, oshima wrote:
> > > don't you want to put win7/win8 versions in different subdirectories?
> > >
> > > Also will there be 200p versions? (+girard for Win high DPI support)
>
> @monica, any update about 200p versions?
Chatted with monica, there is no 200p versions yet.
The new patch puts win7/win8 versions in different sub directories as suggested.
oshima
On 2013/10/01 20:41:27, guohui wrote: > On 2013/10/01 12:14:02, guohui wrote: > > On 2013/09/27 ...
7 years, 2 months ago
(2013-10-01 21:33:34 UTC)
#6
On 2013/10/01 20:41:27, guohui wrote:
> On 2013/10/01 12:14:02, guohui wrote:
> > On 2013/09/27 18:19:36, Monica Dinculescu wrote:
> > > I'm not sure about the 200p versions: the existing buttons in
> > > default_100_percent/win don't seem to have 200p counterparts. I will ask
> > > sgabriel@ about what the plan is.
> > >
> > >
> > > On 2013/09/27 17:47:36, oshima wrote:
> > > > don't you want to put win7/win8 versions in different subdirectories?
> > > >
> > > > Also will there be 200p versions? (+girard for Win high DPI support)
> >
> > @monica, any update about 200p versions?
>
> Chatted with monica, there is no 200p versions yet.
> The new patch puts win7/win8 versions in different sub directories as
suggested.
Can you remove redundant win8/win7 in file names?
guohui
On 2013/10/01 21:33:34, oshima wrote: > On 2013/10/01 20:41:27, guohui wrote: > > On 2013/10/01 ...
7 years, 2 months ago
(2013-10-02 15:51:16 UTC)
#7
On 2013/10/01 21:33:34, oshima wrote:
> On 2013/10/01 20:41:27, guohui wrote:
> > On 2013/10/01 12:14:02, guohui wrote:
> > > On 2013/09/27 18:19:36, Monica Dinculescu wrote:
> > > > I'm not sure about the 200p versions: the existing buttons in
> > > > default_100_percent/win don't seem to have 200p counterparts. I will ask
> > > > sgabriel@ about what the plan is.
> > > >
> > > >
> > > > On 2013/09/27 17:47:36, oshima wrote:
> > > > > don't you want to put win7/win8 versions in different subdirectories?
> > > > >
> > > > > Also will there be 200p versions? (+girard for Win high DPI support)
> > >
> > > @monica, any update about 200p versions?
> >
> > Chatted with monica, there is no 200p versions yet.
> > The new patch puts win7/win8 versions in different sub directories as
> suggested.
>
> Can you remove redundant win8/win7 in file names?
Done.
oshima
lgtm thanks!
7 years, 2 months ago
(2013-10-02 16:19:43 UTC)
#8
lgtm thanks!
guohui
Committed patchset #3 manually as r226481 (presubmit successful).
7 years, 2 months ago
(2013-10-02 17:56:45 UTC)
#9
Message was sent while issue was closed.
Committed patchset #3 manually as r226481 (presubmit successful).
Issue 25035004: New avatar button resources for project mirror
(Closed)
Created 7 years, 2 months ago by guohui
Modified 7 years, 2 months ago
Reviewers: oshima, girard
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 0