Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Issue 2503493002: Reland of "MIPS: Optimize load/store with large offset" (Closed)

Created:
4 years, 1 month ago by dusan.simicic
Modified:
4 years, 1 month ago
Reviewers:
ivica.bogosavljevic, v8-mips-ports, miran.karic, Marija Antic
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "MIPS: Optimize load/store with large offset" Currently, we are using the following sequence for load/store with large offset (offset > 16b): lui at, 0x1234 ori at, at, 0x5678 add at, s0, at lw a0, 0(at) This sequence can be optimized in the following way: lui at, 0x1234 add at, s0, at lw a0, 0x5678(at) BUG= Committed: https://crrev.com/961a45da69b613b819dbadf0c83b2b4ab820c68c Cr-Commit-Position: refs/heads/master@{#40988}

Patch Set 1 #

Patch Set 2 : Add unsigned suffix to constant 0 #

Patch Set 3 : Reland of "MIPS: Optimize load/store with large offset" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -49 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +24 lines, -2 lines 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 14 chunks +63 lines, -32 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 1 4 chunks +10 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dusan.simicic
PTAL
4 years, 1 month ago (2016-11-14 15:02:51 UTC) #2
ivica.bogosavljevic
lgtm with nits: Change the title and description of the patch to: Reland of "MIPS: ...
4 years, 1 month ago (2016-11-15 08:52:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503493002/40001
4 years, 1 month ago (2016-11-15 11:58:18 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-15 12:00:36 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:33:51 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/961a45da69b613b819dbadf0c83b2b4ab820c68c
Cr-Commit-Position: refs/heads/master@{#40988}

Powered by Google App Engine
This is Rietveld 408576698