Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: net/http/http_cache_lookup_manager.h

Issue 2503473004: Server push cancellation: add a new class HttpCacheLookupManager which implements ServerPushDelegate (Closed)
Patch Set: Merge branch 'master' of https://chromium.googlesource.com/chromium/src into SPC_CacheLookupDelegate Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_cache_lookup_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_cache_lookup_manager.h
diff --git a/net/http/http_cache_lookup_manager.h b/net/http/http_cache_lookup_manager.h
new file mode 100644
index 0000000000000000000000000000000000000000..b377290afc9761c8b07c489691eead56bd49a8f4
--- /dev/null
+++ b/net/http/http_cache_lookup_manager.h
@@ -0,0 +1,63 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_HTTP_CACHE_LOOKUP_MANAGER_H_
+#define NET_HTTP_CACHE_LOOKUP_MANAGER_H_
+
+#include "net/base/net_export.h"
+#include "net/http/http_cache.h"
+#include "net/http/http_cache_transaction.h"
+#include "net/spdy/server_push_delegate.h"
+
+namespace net {
+
+// An implementation of ServerPushDelegate that issues an HttpCache::Transaction
+// to lookup whether the response to the pushed URL is cached and cancel the
+// push in that case.
+class NET_EXPORT_PRIVATE HttpCacheLookupManager : public ServerPushDelegate {
+ public:
+ // |http_cache| MUST outlive the HttpCacheLookupManager.
+ HttpCacheLookupManager(HttpCache* http_cache,
+ const NetLogWithSource& net_log);
+ ~HttpCacheLookupManager() override;
+
+ void OnPush(std::unique_ptr<ServerPushHelper> push_helper) override;
+
+ // Invoked when the HttpCache::Transaction for |url| finishes to cancel the
+ // server push if the response to the server push is found cached.
+ void OnLookupComplete(const GURL& url, int rv);
+
+ private:
+ // A class that takes the ownership of ServerPushHelper, issues and owns an
+ // HttpCache::Transaction which lookups the response in cache for the server
+ // push.
+ class LookupTransaction {
+ public:
+ LookupTransaction(std::unique_ptr<ServerPushHelper> push_helper);
+ ~LookupTransaction();
+
+ // Issues an HttpCache::Transaction to lookup whether the response is cached
+ // without header validation.
+ int StartLookup(HttpCache* cache,
+ const CompletionCallback& callback,
+ const NetLogWithSource& net_log);
+
+ void CancelPush();
+
+ private:
+ std::unique_ptr<ServerPushHelper> push_helper_;
+ std::unique_ptr<HttpRequestInfo> request_;
+ std::unique_ptr<HttpTransaction> transaction_;
+ };
+
+ NetLogWithSource net_log_;
+ // HttpCache must outlive the HttpCacheLookupManager.
+ HttpCache* http_cache_;
+ std::map<GURL, std::unique_ptr<LookupTransaction>> lookup_transactions_;
+ base::WeakPtrFactory<HttpCacheLookupManager> weak_factory_;
+};
+
+} // namespace net
+
+#endif // NET_HTTP_CACHE_LOOKUP_MANAGER_H_
« no previous file with comments | « no previous file | net/http/http_cache_lookup_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698