Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2503453004: Add '--adb-path' argument to integration script to modify adb version (Closed)

Created:
4 years, 1 month ago by shenghuazhang
Modified:
4 years, 1 month ago
Reviewers:
nyquist, jbudorick
CC:
xingliu, David Trainor- moved to gerrit, Khushal
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add '--adb-path' argument to integration script to modify adb version - Add '--adb-path' argument in parse. - Set default adb path to the the chromium's adb - Set up adb by using devil_chromium.Initialize BUG=665254 Committed: https://crrev.com/aadd4dcb24b07b0c5cce7220a1207d503a7af898 Cr-Commit-Position: refs/heads/master@{#432112}

Patch Set 1 #

Total comments: 4

Patch Set 2 : john's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M blimp/tools/client_engine_integration.py View 1 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
shenghuazhang
4 years, 1 month ago (2016-11-15 03:12:33 UTC) #2
jbudorick
lgtm w/ nits https://codereview.chromium.org/2503453004/diff/1/blimp/tools/client_engine_integration.py File blimp/tools/client_engine_integration.py (right): https://codereview.chromium.org/2503453004/diff/1/blimp/tools/client_engine_integration.py#newcode26 blimp/tools/client_engine_integration.py:26: ADB_PATH = os.path.join(SRC_PATH, 'third_party', 'android_tools', nit: ...
4 years, 1 month ago (2016-11-15 03:15:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503453004/20001
4 years, 1 month ago (2016-11-15 03:25:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/304053)
4 years, 1 month ago (2016-11-15 03:47:30 UTC) #8
shenghuazhang
Shouldn't have committed the cl; missing LGTM from file owner yet. https://codereview.chromium.org/2503453004/diff/1/blimp/tools/client_engine_integration.py File blimp/tools/client_engine_integration.py (right): ...
4 years, 1 month ago (2016-11-15 03:59:17 UTC) #9
nyquist
lgtm
4 years, 1 month ago (2016-11-15 05:10:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503453004/20001
4 years, 1 month ago (2016-11-15 05:11:22 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 05:15:51 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 05:22:51 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aadd4dcb24b07b0c5cce7220a1207d503a7af898
Cr-Commit-Position: refs/heads/master@{#432112}

Powered by Google App Engine
This is Rietveld 408576698