Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2503433002: [turbofan] Properly allocate constant-folded string. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly allocate constant-folded string. When constant-folding S[K], make sure to return a String, and not the character code as Number. BUG=chromium:664942 R=yangguo@chromium.org Committed: https://crrev.com/566728031025e7b8c171f91cb1e0537ebcb0813b Cr-Commit-Position: refs/heads/master@{#40960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-664942.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-14 11:24:56 UTC) #1
Yang
On 2016/11/14 11:24:56, Benedikt Meurer wrote: Hah. Nice catch. LGTM.
4 years, 1 month ago (2016-11-14 11:43:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503433002/1
4 years, 1 month ago (2016-11-14 11:43:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 11:58:03 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:32:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/566728031025e7b8c171f91cb1e0537ebcb0813b
Cr-Commit-Position: refs/heads/master@{#40960}

Powered by Google App Engine
This is Rietveld 408576698