Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2503423003: Don't crash attempting to JSON print an uninitialized Map. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't crash attempting to JSON print an uninitialized Map. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/618331635503aa258c1f78ff318488b914202e85

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M runtime/observatory/tests/service/service.status View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 1 month ago (2016-11-16 18:02:48 UTC) #2
Florian Schneider
lgtm
4 years, 1 month ago (2016-11-16 18:07:46 UTC) #3
rmacnak
4 years, 1 month ago (2016-11-16 19:14:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
618331635503aa258c1f78ff318488b914202e85 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698