Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2682)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

Issue 2503363003: Fix three causes of blank thumbnails [2nd land] (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/compositor/tab_content_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java
index 57a2d463cef54de1d9294e3fa4c5b069cc2f159a..62dbb5f115cac42dcdf445f3b022b906928c27e1 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java
@@ -12,7 +12,6 @@ import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.ChromeTabbedActivity;
import org.chromium.chrome.browser.compositor.layouts.OverviewModeBehavior;
import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;
-import org.chromium.chrome.browser.ntp.NativePageFactory;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;
@@ -195,11 +194,7 @@ public class TabModelSelectorImpl extends TabModelSelectorBase implements TabMod
@Override
public void onPageLoadStarted(Tab tab, String url) {
String previousUrl = tab.getUrl();
- if (NativePageFactory.isNativePageUrl(previousUrl, tab.isIncognito())) {
- mTabContentManager.invalidateTabThumbnail(tab.getId(), previousUrl);
- } else {
- mTabContentManager.removeTabThumbnail(tab.getId());
- }
+ mTabContentManager.invalidateTabThumbnail(tab.getId(), previousUrl);
}
@Override
« no previous file with comments | « no previous file | chrome/browser/android/compositor/tab_content_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698