Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2503363002: VM: Fix incorrect free in TryReadKernel. (Closed)

Created:
4 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
4 years, 1 month ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix incorrect free in TryReadKernel. SniffForMagicNumber updates buffer pointer to skip snapshot magic number. Thus we have to preserve and pass original buffer pointer to the free(...) call. R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/eb38fb5d6768e11f9255fbb1399179be0043e4c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M runtime/bin/dartutils.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-11-16 13:35:34 UTC) #1
kustermann
lgtm
4 years, 1 month ago (2016-11-16 13:37:51 UTC) #2
Vyacheslav Egorov (Google)
4 years, 1 month ago (2016-11-16 13:41:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb38fb5d6768e11f9255fbb1399179be0043e4c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698