Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc

Issue 2503283003: Add high-precision timing histograms. (Closed)
Patch Set: Change measurement unit. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
diff --git a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
index 0911fd9c545cd3f1f3faac80ae7fc42671b24841..992053a3ad725b2f11c0ffe61582bbc5f1d0092b 100644
--- a/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
+++ b/components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc
@@ -11,6 +11,7 @@
#include "base/macros.h"
#include "base/strings/string_piece.h"
#include "base/test/histogram_tester.h"
+#include "base/time/time.h"
#include "components/subresource_filter/content/common/subresource_filter_messages.h"
#include "components/subresource_filter/content/renderer/ruleset_dealer.h"
#include "components/subresource_filter/core/common/test_ruleset_creator.h"
@@ -83,6 +84,10 @@ constexpr const char kSubresourcesMatchedRules[] =
"SubresourceFilter.DocumentLoad.NumSubresourceLoads.MatchedRules";
constexpr const char kSubresourcesDisallowed[] =
"SubresourceFilter.DocumentLoad.NumSubresourceLoads.Disallowed";
+constexpr const char kEvaluationTotalWallDuration[] =
+ "SubresourceFilter.DocumentLoad.SubresourceEvaluation.TotalWallDuration";
+constexpr const char kEvaluationTotalCPUDuration[] =
+ "SubresourceFilter.DocumentLoad.SubresourceEvaluation.TotalCPUDuration";
} // namespace
@@ -321,6 +326,9 @@ TEST_F(SubresourceFilterAgentTest, Disabled_HistogramSamples) {
histogram_tester.ExpectTotalCount(kSubresourcesEvaluated, 0);
histogram_tester.ExpectTotalCount(kSubresourcesMatchedRules, 0);
histogram_tester.ExpectTotalCount(kSubresourcesDisallowed, 0);
+
+ histogram_tester.ExpectTotalCount(kEvaluationTotalWallDuration, 0);
+ histogram_tester.ExpectTotalCount(kEvaluationTotalCPUDuration, 0);
}
TEST_F(SubresourceFilterAgentTest,
@@ -338,6 +346,9 @@ TEST_F(SubresourceFilterAgentTest,
histogram_tester.ExpectTotalCount(kSubresourcesEvaluated, 0);
histogram_tester.ExpectTotalCount(kSubresourcesMatchedRules, 0);
histogram_tester.ExpectTotalCount(kSubresourcesDisallowed, 0);
+
+ histogram_tester.ExpectTotalCount(kEvaluationTotalWallDuration, 0);
+ histogram_tester.ExpectTotalCount(kEvaluationTotalCPUDuration, 0);
}
TEST_F(SubresourceFilterAgentTest, Enabled_HistogramSamples) {
@@ -376,6 +387,11 @@ TEST_F(SubresourceFilterAgentTest, Enabled_HistogramSamples) {
::testing::ElementsAre(base::Bucket(1, 1), base::Bucket(2, 1)));
EXPECT_THAT(histogram_tester.GetAllSamples(kSubresourcesDisallowed),
::testing::ElementsAre(base::Bucket(1, 1), base::Bucket(2, 1)));
+
+ histogram_tester.ExpectTotalCount(kEvaluationTotalWallDuration, 2);
+ const base::HistogramBase::Count total_count =
+ base::ThreadTicks::IsSupported() ? 2 : 0;
+ histogram_tester.ExpectTotalCount(kEvaluationTotalCPUDuration, total_count);
}
TEST_F(SubresourceFilterAgentTest, DryRun_HistogramSamples) {
@@ -403,6 +419,11 @@ TEST_F(SubresourceFilterAgentTest, DryRun_HistogramSamples) {
histogram_tester.ExpectUniqueSample(kSubresourcesEvaluated, 3, 1);
histogram_tester.ExpectUniqueSample(kSubresourcesMatchedRules, 2, 1);
histogram_tester.ExpectUniqueSample(kSubresourcesDisallowed, 0, 1);
+
+ histogram_tester.ExpectTotalCount(kEvaluationTotalWallDuration, 1);
+ const base::HistogramBase::Count total_count =
+ base::ThreadTicks::IsSupported() ? 1 : 0;
+ histogram_tester.ExpectTotalCount(kEvaluationTotalCPUDuration, total_count);
}
} // namespace subresource_filter

Powered by Google App Engine
This is Rietveld 408576698