Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: components/subresource_filter/content/renderer/document_subresource_filter.h

Issue 2503283003: Add high-precision timing histograms. (Closed)
Patch Set: Change measurement unit. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/subresource_filter/content/renderer/document_subresource_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/subresource_filter/content/renderer/document_subresource_filter.h
diff --git a/components/subresource_filter/content/renderer/document_subresource_filter.h b/components/subresource_filter/content/renderer/document_subresource_filter.h
index fb72370c519f6085f73fb7b294f9eb79984e5e7c..385813124115c53232a66620469e62a14c8b679b 100644
--- a/components/subresource_filter/content/renderer/document_subresource_filter.h
+++ b/components/subresource_filter/content/renderer/document_subresource_filter.h
@@ -13,6 +13,7 @@
#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
+#include "base/time/time.h"
#include "components/subresource_filter/core/common/activation_state.h"
#include "components/subresource_filter/core/common/indexed_ruleset.h"
#include "third_party/WebKit/public/platform/WebDocumentSubresourceFilter.h"
@@ -29,7 +30,6 @@ class DocumentSubresourceFilter
: public blink::WebDocumentSubresourceFilter,
public base::SupportsWeakPtr<DocumentSubresourceFilter> {
public:
- // TODO(pkalinnikov): Add total evaluation time metrics.
struct Statistics {
// The number of subresource loads that went through the allowLoad method.
size_t num_loads_total = 0;
@@ -40,6 +40,10 @@ class DocumentSubresourceFilter
size_t num_loads_evaluated = 0;
size_t num_loads_matching_rules = 0;
size_t num_loads_disallowed = 0;
+
+ // Total time spent in allowLoad() calls while evaluating subresource loads.
+ base::TimeDelta evaluation_total_wall_duration;
+ base::TimeDelta evaluation_total_cpu_duration;
};
// Constructs a new filter that will:
« no previous file with comments | « no previous file | components/subresource_filter/content/renderer/document_subresource_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698