Chromium Code Reviews Chromium Code Reviews
Issue 2503283003:
Add high-precision timing histograms. (Closed)
| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 0b8814dcb5fa9038c933c872745555b49bd0dd77..bed2dfabba75963e50f1c04f31090751c3e604f5 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -62279,6 +62279,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <summary>Microseconds spent in Document::updateStyle.</summary> |
| </histogram> |
| +<histogram name="SubresourceFilter.DocumentLoad.Activation.CPUDuration" |
| + units="us"> |
| + <owner>pkalinnikov@chromium.org</owner> |
| + <summary> |
| + Records how much thread CPU time it takes to decide whether subresource |
| + filtering should be activated for a main frame or subframe. |
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="SubresourceFilter.DocumentLoad.Activation.WallDuration" |
| + units="ms"> |
| + <owner>pkalinnikov@chromium.org</owner> |
| + <summary> |
| + Records how much time it takes to decide whether subresource filtering |
|
engedy
2016/11/16 14:48:08
nit: how long it takes
pkalinnikov
2016/11/17 15:24:32
Done.
|
| + should be activated for a main frame or subframe. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="SubresourceFilter.DocumentLoad.ActivationState" |
| enum="SubresourceFilterActivationState"> |
| <owner>engedy@chromium.org</owner> |
| @@ -62342,6 +62360,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="SubresourceFilter.IndexRuleset.CPUDuration" units="us"> |
| + <owner>pkalinnikov@chromium.org</owner> |
| + <summary> |
| + The total time it took to obtain and index all rules. Does not include time |
|
engedy
2016/11/16 14:48:07
Phrasing suggestion:
The total CPU time it took t
pkalinnikov
2016/11/17 15:24:32
Done.
|
| + when the indexing thread is not doing any work, e.g., waits for an I/O to |
| + complete reading unindexed rules. Recorded every time the RulesetService |
| + kicks off a ruleset indexing process. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="SubresourceFilter.IndexRuleset.NumUnsupportedRules" |
| units="rules"> |
| <owner>engedy@chromium.org</owner> |
| @@ -62378,6 +62406,24 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="SubresourceFilter.SubresourceLoad.Evaluation.CPUDuration" |
| + units="us"> |
| + <owner>pkalinnikov@chromium.org</owner> |
| + <summary> |
| + Whenever a subresource of a document is evaluated against the ruleset, |
| + records the thread CPU time spent for providing the allowLoad decision. |
|
engedy
2016/11/16 14:48:08
nit: spent on calculating. (same below)
pkalinnikov
2016/11/17 15:24:32
Done.
|
| + </summary> |
| +</histogram> |
| + |
| +<histogram name="SubresourceFilter.SubresourceLoad.Evaluation.WallDuration" |
| + units="ms"> |
| + <owner>pkalinnikov@chromium.org</owner> |
| + <summary> |
| + Whenever a subresource of a document is evaluated against the ruleset, |
| + records how much time was spent for providing the allowLoad decision. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="SubresourceFilter.WriteRuleset.ReplaceFileError" |
| enum="PlatformFileError"> |
| <owner>engedy@chromium.org</owner> |
