Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2078)

Unified Diff: chrome/browser/safe_browsing/certificate_reporting_metrics_provider.h

Issue 2503243003: Wire up CertificateReportingService to handle report uploads (Closed)
Patch Set: More documentation for CertificateReportingMetricsProvider Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/certificate_reporting_metrics_provider.h
diff --git a/chrome/browser/safe_browsing/certificate_reporting_metrics_provider.h b/chrome/browser/safe_browsing/certificate_reporting_metrics_provider.h
index aa4ce7a70d579843e828f2a67182d59217423367..1a2ca3f9e04fc40474ee32f35bdd9670bcda85fd 100644
--- a/chrome/browser/safe_browsing/certificate_reporting_metrics_provider.h
+++ b/chrome/browser/safe_browsing/certificate_reporting_metrics_provider.h
@@ -8,10 +8,13 @@
#include "base/macros.h"
#include "components/metrics/metrics_provider.h"
-// When user metrics are about to be uploaded,
+// CertificateReportingService doesn't do its own scheduling when retrying
+// uploads of failed reports. Instead, it piggybacks off on the metrics service
Ilya Sherman 2016/12/23 00:56:48 nit: s/off on/off of
meacer 2016/12/27 18:56:43 Done.
+// scheduler.
+//
+// When the metrics services requests metrics to be uploaded,
// CertificateReportingMetricsProvider looks up the CertificateReportingService
-// for the current profile and tells it to record its metrics before the upload
-// occurs.
+// for the current profile and tells it send all pending reports at once.
class CertificateReportingMetricsProvider : public metrics::MetricsProvider {
public:
CertificateReportingMetricsProvider();

Powered by Google App Engine
This is Rietveld 408576698