chrome/browser/safe_browsing/certificate_reporting_metrics_provider.cc - Issue 2503243003: Wire up CertificateReportingService to handle report uploads

Unified Diff: chrome/browser/safe_browsing/certificate_reporting_metrics_provider.cc

Issue 2503243003: Wire up CertificateReportingService to handle report uploads (Closed)

Patch Set: jialiul, estark comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/browser/chrome_content_browser_client.cc ('K') | « chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc ('k') | chrome/browser/safe_browsing/certificate_reporting_service.h » ('j') | chrome/browser/safe_browsing/certificate_reporting_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/certificate_reporting_metrics_provider.cc

diff --git a/chrome/browser/safe_browsing/certificate_reporting_metrics_provider.cc b/chrome/browser/safe_browsing/certificate_reporting_metrics_provider.cc

index b7304bc2d3d662bde51aa73d9cbc08fb4bb29d9b..fbe349d87d4754fe26d63fecc0aadd6f01486bad 100644

--- a/chrome/browser/safe_browsing/certificate_reporting_metrics_provider.cc

+++ b/chrome/browser/safe_browsing/certificate_reporting_metrics_provider.cc

@@ -14,4 +14,13 @@ CertificateReportingMetricsProvider::CertificateReportingMetricsProvider() {}

CertificateReportingMetricsProvider::~CertificateReportingMetricsProvider() {}

void CertificateReportingMetricsProvider::ProvideGeneralMetrics(

- metrics::ChromeUserMetricsExtension* unused) {}

+ metrics::ChromeUserMetricsExtension* unused) {

+ ProfileManager* profile_manager = g_browser_process->profile_manager();

+ if (!profile_manager)

+ return;

+ CertificateReportingService* service =

+ CertificateReportingServiceFactory::GetForBrowserContext(

estark 2016/12/16 23:39:04 I am very stupid for not realizing this earlier, b

meacer 2016/12/17 01:23:21 That's a scary bug. It looks like NOTIFICATION_PRO

meacer 2016/12/21 23:11:05 I believe this is fixed now. The fix is based on h

+ profile_manager->GetLastUsedProfile());

+ if (service)

+ service->SendPending();