Wire up CertificateReportingService to handle report uploads

chrome/browser/safe_browsing/certificate_reporting_service.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_CERTIFICATE_REPORTING_SERVICE_H_
 #define CHROME_BROWSER_SAFE_BROWSING_CERTIFICATE_REPORTING_SERVICE_H_
 
 #include <map>
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/callback_list.h"
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/threading/thread_checker.h"
 #include "base/time/time.h"
 #include "components/certificate_reporting/error_reporter.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "net/url_request/url_request_context_getter.h"
 
+class Profile;
+
 namespace base {
 class Clock;
 }
 
 namespace net {
 class URLRequestContext;
 class URLRequestContextGetter;
 }
 
+namespace safe_browsing {
+class SafeBrowsingService;
+}
+
 // This service initiates uploads of invalid certificate reports and retries any
 // failed uploads. Each report is retried until it's older than a certain time
 // to live (TTL). Reports older than this TTL are dropped and no more retried,
 // so that the retry list doesn't grow indefinitely.
 //
 // Lifetime and dependencies:
 //
 // CertificateReportingService uses the url request context from SafeBrowsing
 // service. SafeBrowsing service is created before this service, but is also
 // shut down before any KeyedService is shut down. This means that this class
@@ skipping 115 matching lines @@
     // Current report id, starting from zero and monotonically incrementing.
     int current_report_id_;
 
     std::map<int, Report> inflight_reports_;
 
     base::WeakPtrFactory<Reporter> weak_factory_;
 
     DISALLOW_COPY_AND_ASSIGN(Reporter);
   };
 
+  // Observes SafeBrowsing preference changes. An instance of this is created by
+  // ChromeContentBrowserClient to notify the service when SafeBrowsing
+  // or extended reporting is enabled/disabled. This class is introduced to
+  // decouple chrome/browser/ssl from SafeBrowsing.
+  class PreferenceObserver {
+   public:
+    // Called when SafeBrowsing preference changes.
+    virtual void OnPreferenceChanged() = 0;
+
+    virtual ~PreferenceObserver() {}
+  };
+
+  static CertificateReportingService* Create(
+      safe_browsing::SafeBrowsingService* safe_browsing_service,
+      Profile* profile);
+  // Constructor for unit tests:
   CertificateReportingService(
+      safe_browsing::SafeBrowsingService* safe_browsing_service,
       scoped_refptr<net::URLRequestContextGetter> url_request_context_getter,
+      Profile* profile,
       std::unique_ptr<EventObserver> event_observer,
       size_t max_queued_report_count,
       base::TimeDelta max_report_age,
       base::Clock* test_clock);
 
   ~CertificateReportingService() override;
 
   // KeyedService implementation:
   void Shutdown() override;
 
@@ skipping 51 matching lines @@
 
   // If true, reporting is enabled. When SafeBrowsing preferences change, this
   // might be set to false.
   bool enabled_;
 
   // scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
   net::URLRequestContext* url_request_context_;
 
   std::unique_ptr<Reporter> reporter_;
 
+  // Observes SafeBrowsing preference changes (SB is enabled/disabled, extended
+  // reporting is enabled/disabled).
+  std::unique_ptr<PreferenceObserver> preference_observer_;
+
   // Subscription for url request context shutdowns. When this subscription is
   // notified, it means that the SafeBrowsing service is shutting down, and this
   // service must also shut down.
   std::unique_ptr<base::CallbackList<void(void)>::Subscription>
       safe_browsing_service_shutdown_subscription_;
 
   // Observes events from this service. Default implementation doesn't do
   // anything. Tests use this to keep track of sent/failed reports etc.
   std::unique_ptr<EventObserver> event_observer_;
 
   // Maximum number of reports to be queued for retry.
   size_t max_queued_report_count_;
 
   // Maximum age of the reports to be queued for retry, from the time the
   // certificate error was first encountered by the user. Any report older than
   // this age is ignored and is not re-uploaded.
   base::TimeDelta max_report_age_;
 
   // Test clock. If null, system clock is used.
   base::Clock* test_clock_;
 
   // Whether a send has ever been made. Used to verify that test setters are
   // only called after initialization.
   bool made_send_attempt_;
 
   DISALLOW_COPY_AND_ASSIGN(CertificateReportingService);
 };
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_CERTIFICATE_REPORTING_SERVICE_H_