Add enumerations for compressed (E)AC3 sample format

Add enumerations for compressed (E)AC3 sample format

This CL is part of enabling (E)AC3 passthrough feature. The new
enumerations indicate that the audio output is compressed (E)AC3
bitstream instead of PCM samples.

BUG=613385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/59327d6bb57d4ba6ec7d6ba41f5e6f63aa3f77ce
Cr-Commit-Position: refs/heads/master@{#433420}

[AndyWu, 2016-11-16 19:19:47]

Description was changed from

==========
Add enumerations for compressed (E)AC3 sample format

This CL is part of enabling (E)AC3 passthrough feature. The new
enumerations indicate that the audio output is compressed (E)AC3
bitstream instead of PCM samples.

BUG=613385
==========

to

==========
Add enumerations for compressed (E)AC3 sample format

This CL is part of enabling (E)AC3 passthrough feature. The new
enumerations indicate that the audio output is compressed (E)AC3
bitstream instead of PCM samples.

BUG=613385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[AndyWu, 2016-11-16 19:27:38]

Description was changed from

==========
Add enumerations for compressed (E)AC3 sample format

This CL is part of enabling (E)AC3 passthrough feature. The new
enumerations indicate that the audio output is compressed (E)AC3
bitstream instead of PCM samples.

BUG=613385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add enumerations for compressed (E)AC3 sample format

This CL is part of enabling (E)AC3 passthrough feature. The new
enumerations indicate that the audio output is compressed (E)AC3
bitstream instead of PCM samples.

BUG=613385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[AndyWu, 2016-11-16 19:27:38]

tsunghung@chromium.org changed reviewers:
+ chcunningham@chromium.org, dalecurtis@chromium.org

[AndyWu, 2016-11-16 19:29:49]

tsunghung@chromium.org changed reviewers:
+ halliwell@chromium.org

[DaleCurtis, 2016-11-17 00:02:15]

We should choose a common word for this and use it everywhere :) I like
bitstream, though in truth PCM is also a bitstream, so compressed has some
validity. There's also the option of dropping it entirely and having

AUDIO_AC3, AUDIO_EAC3, etc. kSampleFormatAC3. IsCompressedFormat() would make
the most sense in this world.

I'm fine either way so long as we're consistent.

https://codereview.chromium.org/2503233003/diff/1/media/audio/audio_manager_b...
File media/audio/audio_manager_base.cc (right):

https://codereview.chromium.org/2503233003/diff/1/media/audio/audio_manager_b...
media/audio/audio_manager_base.cc:141: // TODO(tsunghung): create passthrough
output stream.
NOTREACHED()?

https://codereview.chromium.org/2503233003/diff/1/media/base/audio_parameters.cc
File media/base/audio_parameters.cc (right):

https://codereview.chromium.org/2503233003/diff/1/media/base/audio_parameters...
media/base/audio_parameters.cc:100: bool AudioParameters::IsCompressedFormat()
const {
IsBitstreamFormat?

https://codereview.chromium.org/2503233003/diff/1/media/base/sample_format.h
File media/base/sample_format.h (right):

https://codereview.chromium.org/2503233003/diff/1/media/base/sample_format.h#...
media/base/sample_format.h:26: kSampleFormatBitstreamAc3,   // Compressed AC3
bitstream.
Just kSampleFormatAC3, ditto for EAC3?

[AndyWu, 2016-11-17 18:56:55]

Thanks a lot for your suggestions.

https://codereview.chromium.org/2503233003/diff/1/media/audio/audio_manager_b...
File media/audio/audio_manager_base.cc (right):

https://codereview.chromium.org/2503233003/diff/1/media/audio/audio_manager_b...
media/audio/audio_manager_base.cc:141: // TODO(tsunghung): create passthrough
output stream.
On 2016/11/17 00:02:15, DaleCurtis wrote:
> NOTREACHED()? 

Done.

https://codereview.chromium.org/2503233003/diff/1/media/base/audio_parameters.cc
File media/base/audio_parameters.cc (right):

https://codereview.chromium.org/2503233003/diff/1/media/base/audio_parameters...
media/base/audio_parameters.cc:100: bool AudioParameters::IsCompressedFormat()
const {
On 2016/11/17 00:02:15, DaleCurtis wrote:
> IsBitstreamFormat?

Done.

https://codereview.chromium.org/2503233003/diff/1/media/base/sample_format.h
File media/base/sample_format.h (right):

https://codereview.chromium.org/2503233003/diff/1/media/base/sample_format.h#...
media/base/sample_format.h:26: kSampleFormatBitstreamAc3,   // Compressed AC3
bitstream.
On 2016/11/17 00:02:15, DaleCurtis wrote:
> Just kSampleFormatAC3, ditto for EAC3?

Done.

[DaleCurtis, 2016-11-17 19:27:24]

lgtm

[AndyWu, 2016-11-17 21:26:31]

The CQ bit was checked by tsunghung@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 21:27:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 21:47:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:47:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[AndyWu, 2016-11-17 22:11:37]

The CQ bit was checked by tsunghung@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 22:13:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 23:57:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 23:57:48]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[AndyWu, 2016-11-18 17:38:12]

The CQ bit was checked by tsunghung@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 17:39:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chcunningham, 2016-11-18 19:10:09]

lgtm :)

[commit-bot: I haz the power, 2016-11-18 20:09:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 20:09:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[AndyWu, 2016-11-18 20:48:09]

The CQ bit was checked by tsunghung@chromium.org

[AndyWu, 2016-11-18 20:48:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2503233003/#ps40001
(title: "Fix proto")

[commit-bot: I haz the power, 2016-11-18 20:49:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 21:39:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 21:39:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[AndyWu, 2016-11-18 21:42:37]

The CQ bit was checked by tsunghung@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 21:43:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[halliwell, 2016-11-18 23:25:24]

On 2016/11/18 21:39:41, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

chromecast/ lgtm

[commit-bot: I haz the power, 2016-11-19 02:23:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 02:23:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[AndyWu, 2016-11-19 06:47:53]

The CQ bit was checked by tsunghung@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 06:48:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 08:07:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 08:08:00]

Dry run: This issue passed the CQ dry run.

[AndyWu, 2016-11-19 16:05:43]

The CQ bit was checked by tsunghung@chromium.org

[commit-bot: I haz the power, 2016-11-19 16:05:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 16:10:20]

Description was changed from

==========
Add enumerations for compressed (E)AC3 sample format

This CL is part of enabling (E)AC3 passthrough feature. The new
enumerations indicate that the audio output is compressed (E)AC3
bitstream instead of PCM samples.

BUG=613385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add enumerations for compressed (E)AC3 sample format

This CL is part of enabling (E)AC3 passthrough feature. The new
enumerations indicate that the audio output is compressed (E)AC3
bitstream instead of PCM samples.

BUG=613385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-19 16:10:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-19 16:11:46]

Description was changed from

==========
Add enumerations for compressed (E)AC3 sample format

This CL is part of enabling (E)AC3 passthrough feature. The new
enumerations indicate that the audio output is compressed (E)AC3
bitstream instead of PCM samples.

BUG=613385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add enumerations for compressed (E)AC3 sample format

This CL is part of enabling (E)AC3 passthrough feature. The new
enumerations indicate that the audio output is compressed (E)AC3
bitstream instead of PCM samples.

BUG=613385
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/59327d6bb57d4ba6ec7d6ba41f5e6f63aa3f77ce
Cr-Commit-Position: refs/heads/master@{#433420}
==========

[commit-bot: I haz the power, 2016-11-19 16:11:47]

Patchset 3 (id:??) landed as
https://crrev.com/59327d6bb57d4ba6ec7d6ba41f5e6f63aa3f77ce
Cr-Commit-Position: refs/heads/master@{#433420}