Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2503213004:
[inspector] Fix expected output of wasm source (Closed)
|
Created:
4 years, 1 month ago by Clemens Hammacher Modified:
4 years, 1 month ago CC:
devtools-reviews_chromium.org, v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[inspector] Fix expected output of wasm source
TBR=ahaas@chromium.org, kozyatinskiy@chromium.org
NOTRY=true
NOTREECHECKS=true
Committed: https://crrev.com/4abdcad232041bc5a83cc147f82cd5a163b22a84
Cr-Commit-Position: refs/heads/master@{#41069}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
The CQ bit was checked by clemensh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
On 2016/11/17 10:39:26, commit-bot: I haz the power wrote: > No L-G-T-M from a valid reviewer yet. > CQ run can only be started by full committers or once the patch has > received an L-G-T-M from a full committer. > Even if an L-G-T-M may have been provided, it was from a non-committer, > _not_ a full super star committer. > Committers are members of the group "project-v8-committers". > Note that this has nothing to do with OWNERS files. lgtm
ahaas@chromium.org changed reviewers: + titzer@chromium.org
lgtm
The CQ bit was checked by clemensh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by clemensh@chromium.org
Description was changed from ========== [inspector] Fix expected output of wasm source TBR=ahaas@chromium.org, kozyatinskiy@chromium.org NOTRY=true ========== to ========== [inspector] Fix expected output of wasm source TBR=ahaas@chromium.org, kozyatinskiy@chromium.org NOTRY=true NOTREECHECKS=true ==========
The CQ bit was checked by clemensh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [inspector] Fix expected output of wasm source TBR=ahaas@chromium.org, kozyatinskiy@chromium.org NOTRY=true NOTREECHECKS=true ========== to ========== [inspector] Fix expected output of wasm source TBR=ahaas@chromium.org, kozyatinskiy@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://crrev.com/4abdcad232041bc5a83cc147f82cd5a163b22a84 Cr-Commit-Position: refs/heads/master@{#41069} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4abdcad232041bc5a83cc147f82cd5a163b22a84 Cr-Commit-Position: refs/heads/master@{#41069} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
