Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2503213003:
Whitelist for autotest extension. (Closed)
DescriptionWhitelist for autotest extension.
The autotest extension is currently loaded as a component extension
using --load-component-extension. We would like to instead whitelist
this extension towards deprecation of the flag.
BUG=chromium:654525
Committed: https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e
Cr-Commit-Position: refs/heads/master@{#433040}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Devlin feedback #Patch Set 3 : rebase #Messages
Total messages: 25 (14 generated)
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
achuith@chromium.org changed reviewers: + rdevlin.cronin@chromium.org
Devlin, PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2503213003/diff/1/chrome/common/extensions/ap... File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/2503213003/diff/1/chrome/common/extensions/ap... chrome/common/extensions/api/_permission_features.json:49: "extension_types": ["extension", "legacy_packaged_app"], Do we still need this to work with legacy packaged apps, or can we remove this entry? https://codereview.chromium.org/2503213003/diff/1/chrome/common/extensions/ap... chrome/common/extensions/api/_permission_features.json:51: "behllobkkfkfnphdnhnkndlbkcpglgmj" // Autotest extension. This should be a hash. See https://chromium.googlesource.com/chromium/src/+/master/chrome/common/extensi...
PTAL, Devlin! https://codereview.chromium.org/2503213003/diff/1/chrome/common/extensions/ap... File chrome/common/extensions/api/_permission_features.json (right): https://codereview.chromium.org/2503213003/diff/1/chrome/common/extensions/ap... chrome/common/extensions/api/_permission_features.json:49: "extension_types": ["extension", "legacy_packaged_app"], On 2016/11/17 18:14:05, Devlin wrote: > Do we still need this to work with legacy packaged apps, or can we remove this > entry? Done. https://codereview.chromium.org/2503213003/diff/1/chrome/common/extensions/ap... chrome/common/extensions/api/_permission_features.json:51: "behllobkkfkfnphdnhnkndlbkcpglgmj" // Autotest extension. On 2016/11/17 18:14:05, Devlin wrote: > This should be a hash. See > https://chromium.googlesource.com/chromium/src/+/master/chrome/common/extensi... Done.
The CQ bit was checked by achuith@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm, thanks!
On 2016/11/17 22:50:38, Devlin wrote: > lgtm, thanks! thank you!
The CQ bit was unchecked by achuith@chromium.org
The CQ bit was checked by achuith@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was checked by achuith@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rdevlin.cronin@chromium.org Link to the patchset: https://codereview.chromium.org/2503213003/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
robbyflya330@gmail.com changed reviewers: + robbyflya330@gmail.com
lgtm
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Whitelist for autotest extension. The autotest extension is currently loaded as a component extension using --load-component-extension. We would like to instead whitelist this extension towards deprecation of the flag. BUG=chromium:654525 ========== to ========== Whitelist for autotest extension. The autotest extension is currently loaded as a component extension using --load-component-extension. We would like to instead whitelist this extension towards deprecation of the flag. BUG=chromium:654525 Committed: https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e Cr-Commit-Position: refs/heads/master@{#433040} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c6060ad28629511e81e3ff52eded40fbd2a9358e Cr-Commit-Position: refs/heads/master@{#433040} |
