Trace table cell position indicies accurately.

Fix TracedLayoutObject crash when table layout is expected to be dirty.

Cell's position should not be traced if there is a risk
of dirty layout in order to prevent assertion crash.

BUG=664271
Committed: https://crrev.com/b8c29bca7e952d293a4e513d5253cfa95ab0ba4c
Cr-Commit-Position: refs/heads/master@{#433239}

[kraynov, 2016-11-16 02:21:57]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[kraynov, 2016-11-16 02:22:22]

kraynov@chromium.org changed reviewers:
+ primiano@chromium.org

[kraynov, 2016-11-16 02:22:23]

PTAL

[commit-bot: I haz the power, 2016-11-16 02:22:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 02:49:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 02:49:14]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Primiano Tucci (use gerrit), 2016-11-16 13:14:01]

primiano@chromium.org changed reviewers:
+ kouhei@chromium.org

[Primiano Tucci (use gerrit), 2016-11-16 13:14:02]

adding +kouhei as OWNER

In the meantime, I find the commit title pretty obscure.
I think it should be something like

"Fix TracedLayoutObject assertions when table layout is dirty"

[kraynov, 2016-11-16 18:56:07]

Description was changed from

==========
Trace table cell position indicies accurately.

Cell's position should not be traced if there is a risk
of dirty layout in order to prevent assertion crash.

BUG=664271
==========

to

==========
Fix TracedLayoutObject crash when table layout is expected to be dirty.

Cell's position should not be traced if there is a risk
of dirty layout in order to prevent assertion crash.

BUG=664271
==========

[kraynov, 2016-11-17 22:36:16]

kraynov@chromium.org changed reviewers:
+ dgrogan@chromium.org, wangxianzhu@chromium.org

[kraynov, 2016-11-17 22:36:17]

+dgrogan
+wangxianzhu
Could you please review this change in //third_party/WebKit/Source/core/layout?
Thank you!

[kouhei (in TOK), 2016-11-17 22:40:01]

https://codereview.chromium.org/2503163003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/TracedLayoutObject.cpp (right):

https://codereview.chromium.org/2503163003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/TracedLayoutObject.cpp:73: if
(traceGeometry && object.isTableCell()) {
Should we really dump the row/col to 0 if traceGeometry is false?

[Xianzhu, 2016-11-17 22:43:22]

lgtm, with other reviewers' comments to be addressed.

[kraynov, 2016-11-17 22:51:37]

The CQ bit was checked by kraynov@chromium.org to run a CQ dry run

[kraynov, 2016-11-17 22:52:14]

https://codereview.chromium.org/2503163003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/TracedLayoutObject.cpp (right):

https://codereview.chromium.org/2503163003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/TracedLayoutObject.cpp:73: if
(traceGeometry && object.isTableCell()) {
On 2016/11/17 22:40:01, kouhei wrote:
> Should we really dump the row/col to 0 if traceGeometry is false?

Thanks! Fixed.

[commit-bot: I haz the power, 2016-11-17 22:53:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kouhei (in TOK), 2016-11-17 22:54:11]

lgtm

[commit-bot: I haz the power, 2016-11-18 00:57:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:57:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[kraynov, 2016-11-18 17:34:35]

The CQ bit was checked by kraynov@chromium.org

[kraynov, 2016-11-18 17:34:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2503163003/#ps20001
(title: "logic")

[commit-bot: I haz the power, 2016-11-18 17:35:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 18:15:45]

Description was changed from

==========
Fix TracedLayoutObject crash when table layout is expected to be dirty.

Cell's position should not be traced if there is a risk
of dirty layout in order to prevent assertion crash.

BUG=664271
==========

to

==========
Fix TracedLayoutObject crash when table layout is expected to be dirty.

Cell's position should not be traced if there is a risk
of dirty layout in order to prevent assertion crash.

BUG=664271
==========

[commit-bot: I haz the power, 2016-11-18 18:15:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 18:20:39]

Description was changed from

==========
Fix TracedLayoutObject crash when table layout is expected to be dirty.

Cell's position should not be traced if there is a risk
of dirty layout in order to prevent assertion crash.

BUG=664271
==========

to

==========
Fix TracedLayoutObject crash when table layout is expected to be dirty.

Cell's position should not be traced if there is a risk
of dirty layout in order to prevent assertion crash.

BUG=664271

Committed: https://crrev.com/b8c29bca7e952d293a4e513d5253cfa95ab0ba4c
Cr-Commit-Position: refs/heads/master@{#433239}
==========

[commit-bot: I haz the power, 2016-11-18 18:20:40]

Patchset 2 (id:??) landed as
https://crrev.com/b8c29bca7e952d293a4e513d5253cfa95ab0ba4c
Cr-Commit-Position: refs/heads/master@{#433239}