Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: services/ui/ws/gpu_service_proxy.h

Issue 2503113002: mus: Get GpuMemoryBuffer from gpu process when possible. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/gpu_service_proxy.h
diff --git a/services/ui/ws/gpu_service_proxy.h b/services/ui/ws/gpu_service_proxy.h
index c85b66f5f9cabdd228f351f5b02765b7a8441778..514c53b548af6accdb2883721deb96dade77c360 100644
--- a/services/ui/ws/gpu_service_proxy.h
+++ b/services/ui/ws/gpu_service_proxy.h
@@ -18,19 +18,18 @@
namespace ui {
-class GpuServiceInternal;
class MusGpuMemoryBufferManager;
namespace ws {
class GpuServiceProxyDelegate;
-// The proxy implementation that relays requests from clients to the real
-// service implementation in the GPU process over mojom.GpuServiceInternal.
-class GpuServiceProxy : public mojom::GpuService {
+// Sets up connection from clients to the real service implementation in the GPU
+// process.
+class GpuServiceProxy {
public:
explicit GpuServiceProxy(GpuServiceProxyDelegate* delegate);
- ~GpuServiceProxy() override;
+ ~GpuServiceProxy();
void Add(mojom::GpuServiceRequest request);
@@ -40,28 +39,11 @@ class GpuServiceProxy : public mojom::GpuService {
private:
void OnInitialized(const gpu::GPUInfo& gpu_info);
- void OnGpuChannelEstablished(const EstablishGpuChannelCallback& callback,
- int32_t client_id,
- mojo::ScopedMessagePipeHandle channel_handle);
-
- // mojom::GpuService overrides:
- void EstablishGpuChannel(
- const EstablishGpuChannelCallback& callback) override;
- void CreateGpuMemoryBuffer(
- gfx::GpuMemoryBufferId id,
- const gfx::Size& size,
- gfx::BufferFormat format,
- gfx::BufferUsage usage,
- const mojom::GpuService::CreateGpuMemoryBufferCallback& callback)
- override;
- void DestroyGpuMemoryBuffer(gfx::GpuMemoryBufferId id,
- const gpu::SyncToken& sync_token) override;
GpuServiceProxyDelegate* const delegate_;
int32_t next_client_id_;
scoped_refptr<base::SingleThreadTaskRunner> main_thread_task_runner_;
mojom::GpuServiceInternalPtr gpu_service_;
- mojo::BindingSet<mojom::GpuService> bindings_;
gpu::GPUInfo gpu_info_;
std::unique_ptr<MusGpuMemoryBufferManager> gpu_memory_buffer_manager_;
GpuMain gpu_main_;

Powered by Google App Engine
This is Rietveld 408576698