Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2782)

Unified Diff: appengine/swarming/ui/res/imp/taskpage/task-page.html

Issue 2503083002: Fix task-page docs and clarify output returning nothing (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/swarming/ui/res/imp/taskpage/task-page.html
diff --git a/appengine/swarming/ui/res/imp/taskpage/task-page.html b/appengine/swarming/ui/res/imp/taskpage/task-page.html
index 6e5de535369522dd93a135cd46bd8eb75828983c..f47384315fa559ea79895ef054ecf6ca6993ed28 100644
--- a/appengine/swarming/ui/res/imp/taskpage/task-page.html
+++ b/appengine/swarming/ui/res/imp/taskpage/task-page.html
@@ -499,7 +499,7 @@
<iframe id="miloFrame" class="milo tabbed" src$="[[_getDisplayServerLink(_server_details.display_server_url_template,task_id)]]"></iframe>
</template>
<template is="dom-if" if="[[_show_raw]]">
- <div class="code stdout tabbed">[[_stdout]]</div>
+ <div class="code stdout tabbed">[[_rawOutput(_stdout,_result)]]</div>
</template>
</div>
</div>
@@ -637,6 +637,10 @@
return result.try_number > 1;
},
+ _empty: function(array) {
+ return !array || array.length == 0;
+ },
+
_expires: function(request) {
var delta = parseInt(request.expiration_secs);
if (delta) {
@@ -723,6 +727,16 @@
this.$.prompt.open();
},
+ _rawOutput: function(stdout, result) {
+ if (stdout) {
+ return stdout;
+ }
+ if (result.state === "PENDING" || result.state === "RUNNING") {
+ return "[No output yet]";
+ }
+ return "[No output received]";
+ },
+
_refresh: function() {
this.$.data.reload();
},
@@ -778,16 +792,10 @@
return dims.length + 1;
},
- _empty: function(array) {
- return !array || array.length == 0;
- },
-
_supportsMilo: function(request, showRaw) {
return !showRaw && request && this._tag(request, "allow_milo");
},
-
-
_toggleDetails: function() {
this.set("_request_detail", !this._request_detail);
},
« no previous file with comments | « appengine/swarming/ui/res/imp/tasklist/task-filters.html ('k') | appengine/swarming/ui/res/imp/taskpage/task-page-data.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698