media: Inform VideoBlit/MFTransform of video color information

ui/gfx/color_space.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_COLOR_SPACE_H_
 #define UI_GFX_COLOR_SPACE_H_
 
 #include <stdint.h>
 
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "ui/gfx/gfx_export.h"
 
 namespace IPC {
 template <class P>
 struct ParamTraits;
 }  // namespace IPC
 
 template <typename T>
 class sk_sp;
 class SkColorSpace;
 
+namespace media {
+class DXVAVideoDecodeAccelerator;
+};
+
 namespace gfx {
 
 class ICCProfile;
 class ColorSpaceToColorSpaceTransform;
 
 // Used to represet a color space for the purpose of color conversion.
 // This is designed to be safe and compact enough to send over IPC
 // between any processes.
 class GFX_EXPORT ColorSpace {
  public:
@@ skipping 123 matching lines @@
   static ColorSpace CreateJpeg();
   static ColorSpace CreateREC601();
   static ColorSpace CreateREC709();
 
   bool operator==(const ColorSpace& other) const;
   bool operator!=(const ColorSpace& other) const;
   bool operator<(const ColorSpace& other) const;
 
   // Note that this may return nullptr.
   sk_sp<SkColorSpace> ToSkColorSpace() const;
   static ColorSpace FromSkColorSpace(const sk_sp<SkColorSpace>& sk_color_space);

[ccameron, 2016/11/15 19:24:00]

I think it would be better to have accessor functions to query these properties
from the ColorSpace:

DXVA2_VideoPrimaries GetDXVA2VideoPrimaries() const;
DXVA2_VideoTransferFunction GetDXVA2TransferFunction() const;

If there are concerns about pulling in too many system headers in this file, we
could create a helper class in a color_space_win.h.

[hubbe, 2016/11/16 18:29:02]

That seems like overkill to me.

I assume the reason for this is to make it easier to replace the implementation
in the future. However, it's just trading slightly more work now, for slightly
less work later.

It would be different if these functions would be used in more than one place.
However, in this case I think we have the opposite as we're going to need a
different enum translation for the dx11 case in DXVAVieoDecodeAccelerator.

 
  private:
   PrimaryID primaries_ = PrimaryID::UNSPECIFIED;
   TransferID transfer_ = TransferID::UNSPECIFIED;
   MatrixID matrix_ = MatrixID::UNSPECIFIED;
   RangeID range_ = RangeID::LIMITED;
 
   // Only used if primaries_ == PrimaryID::CUSTOM
   float custom_primary_matrix_[12];
 
   // This is used to look up the ICCProfile from which this ColorSpace was
   // created, if possible.
   uint64_t icc_profile_id_ = 0;
 
   friend class ICCProfile;
   friend class ColorSpaceToColorSpaceTransform;
   friend struct IPC::ParamTraits<gfx::ColorSpace>;
+  friend class media::DXVAVideoDecodeAccelerator;
   FRIEND_TEST_ALL_PREFIXES(SimpleColorSpace, GetColorSpace);
 };
 
 }  // namespace gfx
 
 #endif  // UI_GFX_COLOR_SPACE_H_