Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 2503033003: Remove all enabled data detectors. (Closed)

Created:
4 years, 1 month ago by michaeldo
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all enabled data detectors. Due to the failures seen with the calendarEvent data detector and potential undiscovered failures of the flight number data detector, both data detectors will be removed. BUG=620878, 662962 Committed: https://crrev.com/d60b92115599fb6a2a81175d08daed171414bcdd Cr-Commit-Position: refs/heads/master@{#432301}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M ios/web/web_state/ui/wk_web_view_configuration_provider.mm View 1 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
michaeldo
4 years, 1 month ago (2016-11-15 23:13:14 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2503033003/diff/1/ios/web/web_state/ui/wk_web_view_configuration_provider.mm File ios/web/web_state/ui/wk_web_view_configuration_provider.mm (right): https://codereview.chromium.org/2503033003/diff/1/ios/web/web_state/ui/wk_web_view_configuration_provider.mm#newcode10 ios/web/web_state/ui/wk_web_view_configuration_provider.mm:10: #include "base/ios/ios_util.h" Do we still need this include?
4 years, 1 month ago (2016-11-15 23:19:51 UTC) #3
michaeldo
https://codereview.chromium.org/2503033003/diff/1/ios/web/web_state/ui/wk_web_view_configuration_provider.mm File ios/web/web_state/ui/wk_web_view_configuration_provider.mm (right): https://codereview.chromium.org/2503033003/diff/1/ios/web/web_state/ui/wk_web_view_configuration_provider.mm#newcode10 ios/web/web_state/ui/wk_web_view_configuration_provider.mm:10: #include "base/ios/ios_util.h" On 2016/11/15 23:19:51, Eugene But wrote: > ...
4 years, 1 month ago (2016-11-15 23:53:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2503033003/20001
4 years, 1 month ago (2016-11-15 23:54:03 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 00:09:11 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 00:12:13 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d60b92115599fb6a2a81175d08daed171414bcdd
Cr-Commit-Position: refs/heads/master@{#432301}

Powered by Google App Engine
This is Rietveld 408576698