Issue 250303002: android scripts respect SKIA_OUT, if already set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 250303002: android scripts respect SKIA_OUT, if already set. (Closed)

Created:
6 years, 8 months ago by hal.canary

Modified:
6 years, 8 months ago

Reviewers:
djsollen, scroggo, mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

android scripts respect SKIA_OUT, if already set. Committed: http://code.google.com/p/skia/source/detail?r=14350

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	platform_tools/android/bin/android_setup.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hal.canary

Example use case: cd "$SKIA_SRC_DIR" export DEVICE_ID=nexus_4 export BUILDTYPE=Release export SKIA_OUT="${HOME}/build/skia/android-${DEVICE_ID}" platform_tools/android/bin/android_ninja tests platform_tools/android/bin/android_run_skia tests

6 years, 8 months ago (2014-04-23 21:28:58 UTC) #1

scroggo

Derek or Mike is a better reviewer. One of these days I'll study up on ...

6 years, 8 months ago (2014-04-23 21:44:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/250303002/1

6 years, 8 months ago (2014-04-24 13:22:19 UTC) #5

Message was sent while issue was closed.

Change committed as 14350

Expand Messages | Collapse Messages