Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2502953002: Report test locations in the test launcher json summary. (Closed)

Created:
4 years, 1 month ago by alex-ac
Modified:
4 years, 1 month ago
CC:
chromium-reviews, Sergiy Byelozyorov
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report test locations in the test launcher json summary. Saving file/line of test declaration in machine-readable format allows automatically find owners of broken/flacky tests. BUG= Committed: https://crrev.com/0e561e186e3eff8cf8eb123e115868ce8ecae6ee Cr-Commit-Position: refs/heads/master@{#432462}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix review issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M base/test/launcher/test_results_tracker.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Paweł Hajdan Jr.
Thanks for the patch! Do you have some effort related to flakiness? I'd be interested ...
4 years, 1 month ago (2016-11-16 08:13:58 UTC) #3
alex-ac
> Do you have some effort related to flakiness? I'd be interested - also consider ...
4 years, 1 month ago (2016-11-16 08:44:25 UTC) #4
Paweł Hajdan Jr.
LGTM
4 years, 1 month ago (2016-11-16 09:25:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502953002/20001
4 years, 1 month ago (2016-11-16 09:27:15 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-16 11:47:34 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0e561e186e3eff8cf8eb123e115868ce8ecae6ee Cr-Commit-Position: refs/heads/master@{#432462}
4 years, 1 month ago (2016-11-16 11:49:32 UTC) #11
Sergiy Byelozyorov
4 years, 1 month ago (2016-11-16 12:09:00 UTC) #13
Message was sent while issue was closed.
Wow! This is so cool. We have exactly same problem and there couldn't have been
better time for this CL to land. Thanks for much.

Powered by Google App Engine
This is Rietveld 408576698