Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2502923003: Add IORef capability to GrSurfaceProxy objects - take 2 (Closed)

Created:
4 years, 1 month ago by robertphillips
Modified:
4 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add IORef capability to GrSurfaceProxy objects - take 2 Re-landing of https://skia-review.googlesource.com/c/4734/ (Add IORef capability to GrSurfaceProxy objects) with fixes for: platforms that don't support discards. memory leak due to copying over of GrSurfaceProxy's creation ref to instantiated GrSurface in instantiate() GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4827 BUG=skia: Change-Id: If0b695d5cafc5ef3fdd251c38262849d09e5d27f Committed: https://skia.googlesource.com/skia/+/1125a030c726854f94fd2b8eed49d1323fc1d038

Patch Set 1 #

Patch Set 2 : Fixed bug in transferRefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+295 lines, -6 lines) Patch
M gn/tests.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrGpuResource.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/private/GrSurfaceProxy.h View 1 2 chunks +85 lines, -6 lines 0 comments Download
M src/gpu/GrSurfaceProxy.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/ProxyRefTest.cpp View 1 1 chunk +205 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
robertphillips
4 years, 1 month ago (2016-11-16 16:05:42 UTC) #5
bsalomon
lgtm
4 years, 1 month ago (2016-11-16 16:11:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502923003/20001
4 years, 1 month ago (2016-11-16 16:18:09 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 19:17:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1125a030c726854f94fd2b8eed49d1323fc1d038

Powered by Google App Engine
This is Rietveld 408576698