Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2502913002: Add expectations on virtual/mojo-loading tests whose base tests have expectations (Closed)

Created:
4 years, 1 month ago by yhirano
Modified:
4 years, 1 month ago
Reviewers:
tzik
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add expectations on virtual/mojo-loading tests whose base tests have expectations If a test X has a TestExpecation entry, virtual/mojo-loading/X should have an entry as well. BUG=659917, 520194, 518987, 446385, 665165 Committed: https://crrev.com/1a8d96b6418a9dda53ef147a95ef721ad5daaa6e Cr-Commit-Position: refs/heads/master@{#432150}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 5 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
yhirano
4 years, 1 month ago (2016-11-15 07:24:30 UTC) #7
tzik
lgtm
4 years, 1 month ago (2016-11-15 09:08:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502913002/20001
4 years, 1 month ago (2016-11-15 09:09:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-15 09:13:45 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 09:16:51 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a8d96b6418a9dda53ef147a95ef721ad5daaa6e
Cr-Commit-Position: refs/heads/master@{#432150}

Powered by Google App Engine
This is Rietveld 408576698