Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2502903002: MD History: Add margin to sidebar items so focus outline shows fully (Closed)

Created:
4 years, 1 month ago by tsergeant
Modified:
4 years, 1 month ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Add margin to sidebar items so focus outline shows fully This adds 4px of spacing to the end of each sidebar item, which is sufficient to allow the outline to show without being cropped. BUG=655503 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/db319346f11bfeac596508b7183eaf1e320d3b0b Cr-Commit-Position: refs/heads/master@{#432132}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/side_bar.html View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
tsergeant
4 years, 1 month ago (2016-11-15 02:45:02 UTC) #3
calamity
lgtm
4 years, 1 month ago (2016-11-15 03:27:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502903002/1
4 years, 1 month ago (2016-11-15 06:22:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 06:27:16 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 06:30:11 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db319346f11bfeac596508b7183eaf1e320d3b0b
Cr-Commit-Position: refs/heads/master@{#432132}

Powered by Google App Engine
This is Rietveld 408576698