Issue 25029002: [DevTools] Enable deleting of a snippet by pressing delete key

Issue 25029002: [DevTools] Enable deleting of a snippet by pressing delete key (Closed)

Created:
7 years, 2 months ago by vanihegde

Modified:
7 years, 2 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, vanivhegde, vivekg__

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[DevTools] Enable deleting of a snippet by pressing delete key This patch enables deleting a snippet by pressing delete key. Currently to delete a snippet one has to right click and click on 'Remove' option of the context menu. R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158528

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review comment incorporated #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	M	Source/devtools/front_end/NavigatorView.js	View	1	2 chunks	+13 lines, -0 lines	0 comments	Download
	M	Source/devtools/front_end/SourcesNavigator.js	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vsevik

https://codereview.chromium.org/25029002/diff/1/Source/devtools/front_end/NavigatorView.js File Source/devtools/front_end/NavigatorView.js (right): https://codereview.chromium.org/25029002/diff/1/Source/devtools/front_end/NavigatorView.js#newcode187 Source/devtools/front_end/NavigatorView.js:187: _sourceDeleted: function(uiSourceCode) Please rename it to sourceDeleted. Underscore means ...

7 years, 2 months ago (2013-09-27 12:23:18 UTC) #2

vanihegde

Thanks for the review. I have renamed the function. Please have a look.

7 years, 2 months ago (2013-09-30 03:30:42 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/25029002/6001

7 years, 2 months ago (2013-09-30 08:34:33 UTC) #5

Message was sent while issue was closed.

Change committed as 158528

Expand Messages | Collapse Messages