Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2502893002: Update Debian and Ubuntu Apache configuration. (Closed)

Created:
4 years, 1 month ago by Jack Bates
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, qyearsley
CC:
chromium-reviews, blink-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Debian and Ubuntu Apache configuration. Support PHP 7 for Stretch, Xenial and later, and version 5 for Jessie, Wily and earlier. BUG=621694 Committed: https://crrev.com/a13cddf67f1d46f26103cc2f6704086d9d9a812e Cr-Commit-Position: refs/heads/master@{#432542}

Patch Set 1 #

Patch Set 2 : Avoid duplication #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/apache_config/debian-httpd-2.4.conf View 1 2 chunks +9 lines, -11 lines 1 comment Download

Messages

Total messages: 18 (9 generated)
Jack Bates
4 years, 1 month ago (2016-11-15 02:30:32 UTC) #3
Jack Bates
The latest CL drops the duplicated configuration. https://codereview.chromium.org/2502893002/diff/40001/third_party/WebKit/Tools/Scripts/apache_config/debian-httpd-2.4.conf File third_party/WebKit/Tools/Scripts/apache_config/debian-httpd-2.4.conf (left): https://codereview.chromium.org/2502893002/diff/40001/third_party/WebKit/Tools/Scripts/apache_config/debian-httpd-2.4.conf#oldcode116 third_party/WebKit/Tools/Scripts/apache_config/debian-httpd-2.4.conf:116: <IfModule mod_php5.c> ...
4 years, 1 month ago (2016-11-15 15:48:47 UTC) #6
qyearsley
On 2016/11/15 at 15:48:47, jack wrote: > The latest CL drops the duplicated configuration. > ...
4 years, 1 month ago (2016-11-15 17:12:37 UTC) #7
Dirk Pranke
lgtm also.
4 years, 1 month ago (2016-11-15 23:19:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502893002/40001
4 years, 1 month ago (2016-11-16 00:19:27 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/338118)
4 years, 1 month ago (2016-11-16 01:14:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502893002/40001
4 years, 1 month ago (2016-11-16 16:31:27 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-16 17:41:55 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 17:49:41 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a13cddf67f1d46f26103cc2f6704086d9d9a812e
Cr-Commit-Position: refs/heads/master@{#432542}

Powered by Google App Engine
This is Rietveld 408576698