Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 2502863002: Add UI DevTools under chrome://inspect/#other (Closed)
Patch Set: Add ui_devtools to BUILD file Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/inspect_ui.cc
diff --git a/chrome/browser/ui/webui/inspect_ui.cc b/chrome/browser/ui/webui/inspect_ui.cc
index 28419a934f4e309531b5d3f456d20e2bffc3f365..f4d9b5f9a6fe372ac747ab6e53367e3724066ce2 100644
--- a/chrome/browser/ui/webui/inspect_ui.cc
+++ b/chrome/browser/ui/webui/inspect_ui.cc
@@ -39,6 +39,7 @@ namespace {
const char kInitUICommand[] = "init-ui";
const char kInspectCommand[] = "inspect";
+const char kInspectUiCommand[] = "inspect-ui";
dgozman 2016/11/15 23:47:08 inspect-additional
Sarmad Hashmi 2016/11/16 01:42:57 Done.
const char kActivateCommand[] = "activate";
const char kCloseCommand[] = "close";
const char kReloadCommand[] = "reload";
@@ -72,6 +73,7 @@ class InspectMessageHandler : public WebUIMessageHandler {
void HandleInitUICommand(const base::ListValue* args);
void HandleInspectCommand(const base::ListValue* args);
+ void HandleInspectUiCommand(const base::ListValue* args);
void HandleActivateCommand(const base::ListValue* args);
void HandleCloseCommand(const base::ListValue* args);
void HandleReloadCommand(const base::ListValue* args);
@@ -94,6 +96,10 @@ void InspectMessageHandler::RegisterMessages() {
web_ui()->RegisterMessageCallback(kInspectCommand,
base::Bind(&InspectMessageHandler::HandleInspectCommand,
base::Unretained(this)));
+ web_ui()->RegisterMessageCallback(
+ kInspectUiCommand,
+ base::Bind(&InspectMessageHandler::HandleInspectUiCommand,
+ base::Unretained(this)));
web_ui()->RegisterMessageCallback(kActivateCommand,
base::Bind(&InspectMessageHandler::HandleActivateCommand,
base::Unretained(this)));
@@ -150,6 +156,19 @@ void InspectMessageHandler::HandleInspectCommand(const base::ListValue* args) {
inspect_ui_->Inspect(source, id);
}
+void InspectMessageHandler::HandleInspectUiCommand(
+ const base::ListValue* args) {
+ std::string url;
+ if (ParseStringArgs(args, &url, nullptr)) {
+ WebContents* inspect_ui = web_ui()->GetWebContents();
+ web_ui()->GetWebContents()->GetDelegate()->OpenURLFromTab(
+ inspect_ui,
+ content::OpenURLParams(GURL(url), content::Referrer(),
+ WindowOpenDisposition::NEW_FOREGROUND_TAB,
+ ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false));
+ }
+}
+
void InspectMessageHandler::HandleActivateCommand(const base::ListValue* args) {
std::string source;
std::string id;

Powered by Google App Engine
This is Rietveld 408576698