Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/browser/resources/inspect/inspect.js

Issue 2502863002: Add UI DevTools under chrome://inspect/#other (Closed)
Patch Set: Add ui_devtools to BUILD file Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/inspect/inspect.js
diff --git a/chrome/browser/resources/inspect/inspect.js b/chrome/browser/resources/inspect/inspect.js
index f0bfd203c8b236cb31063434cfbbc78a85b1df35..7460c67b99174bd8db56648b392986ebf54f7d08 100644
--- a/chrome/browser/resources/inspect/inspect.js
+++ b/chrome/browser/resources/inspect/inspect.js
@@ -123,6 +123,8 @@ function populateLocalTargets(data) {
addToWorkersList(data[i]);
else if (data[i].type === 'service_worker')
addToServiceWorkersList(data[i]);
+ else if (data[i].type === 'ui_devtools')
+ addUiDevToolsToOthersList(data[i]);
else
addToOthersList(data[i]);
}
@@ -428,6 +430,10 @@ function addToOthersList(data) {
addTargetToList(data, $('others-list'), ['url']);
}
+function addUiDevToolsToOthersList(data) {
+ addTargetToList(data, $('others-list'), ['name', 'url']);
+}
+
function formatValue(data, property) {
var value = data[property];
@@ -567,7 +573,10 @@ function addTargetToList(data, list, properties) {
actionBox.className = 'actions';
subrowBox.appendChild(actionBox);
- if (!data.hasCustomInspectAction) {
+ if (data.isUiDevTools) {
+ addActionLink(row, 'inspect',
+ sendCommand.bind(null, 'inspect-ui', data.url), false);
+ } else if (!data.hasCustomInspectAction) {
addActionLink(row, 'inspect', sendTargetCommand.bind(null, 'inspect', data),
data.hasNoUniqueId || data.adbAttachedForeign);
}

Powered by Google App Engine
This is Rietveld 408576698