Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Side by Side Diff: chrome/browser/resources/inspect/inspect.js

Issue 2502863002: Add UI DevTools under chrome://inspect/#other (Closed)
Patch Set: Add ui_devtools to BUILD file Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var MIN_VERSION_TAB_CLOSE = 25; 5 var MIN_VERSION_TAB_CLOSE = 25;
6 var MIN_VERSION_TARGET_ID = 26; 6 var MIN_VERSION_TARGET_ID = 26;
7 var MIN_VERSION_NEW_TAB = 29; 7 var MIN_VERSION_NEW_TAB = 29;
8 var MIN_VERSION_TAB_ACTIVATE = 30; 8 var MIN_VERSION_TAB_ACTIVATE = 30;
9 var WEBRTC_SERIAL = 'WEBRTC'; 9 var WEBRTC_SERIAL = 'WEBRTC';
10 10
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 if (data[i].type === 'page') 116 if (data[i].type === 'page')
117 addToPagesList(data[i]); 117 addToPagesList(data[i]);
118 else if (data[i].type === 'background_page') 118 else if (data[i].type === 'background_page')
119 addToExtensionsList(data[i]); 119 addToExtensionsList(data[i]);
120 else if (data[i].type === 'app') 120 else if (data[i].type === 'app')
121 addToAppsList(data[i]); 121 addToAppsList(data[i]);
122 else if (data[i].type === 'shared_worker') 122 else if (data[i].type === 'shared_worker')
123 addToWorkersList(data[i]); 123 addToWorkersList(data[i]);
124 else if (data[i].type === 'service_worker') 124 else if (data[i].type === 'service_worker')
125 addToServiceWorkersList(data[i]); 125 addToServiceWorkersList(data[i]);
126 else if (data[i].type === 'ui_devtools')
127 addUiDevToolsToOthersList(data[i]);
126 else 128 else
127 addToOthersList(data[i]); 129 addToOthersList(data[i]);
128 } 130 }
129 } 131 }
130 132
131 function showIncognitoWarning() { 133 function showIncognitoWarning() {
132 $('devices-incognito').hidden = false; 134 $('devices-incognito').hidden = false;
133 } 135 }
134 136
135 function alreadyDisplayed(element, data) { 137 function alreadyDisplayed(element, data) {
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 var row = addTargetToList( 423 var row = addTargetToList(
422 data, $('service-workers-list'), ['name', 'description', 'url']); 424 data, $('service-workers-list'), ['name', 'description', 'url']);
423 addActionLink(row, 'terminate', 425 addActionLink(row, 'terminate',
424 sendTargetCommand.bind(null, 'close', data), false); 426 sendTargetCommand.bind(null, 'close', data), false);
425 } 427 }
426 428
427 function addToOthersList(data) { 429 function addToOthersList(data) {
428 addTargetToList(data, $('others-list'), ['url']); 430 addTargetToList(data, $('others-list'), ['url']);
429 } 431 }
430 432
433 function addUiDevToolsToOthersList(data) {
434 addTargetToList(data, $('others-list'), ['name', 'url']);
435 }
436
431 function formatValue(data, property) { 437 function formatValue(data, property) {
432 var value = data[property]; 438 var value = data[property];
433 439
434 if (property == 'name' && value == '') { 440 if (property == 'name' && value == '') {
435 value = 'untitled'; 441 value = 'untitled';
436 } 442 }
437 443
438 var text = value ? String(value) : ''; 444 var text = value ? String(value) : '';
439 if (text.length > 100) 445 if (text.length > 100)
440 text = text.substring(0, 100) + '\u2026'; 446 text = text.substring(0, 100) + '\u2026';
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 subrow.className = 'subrow'; 566 subrow.className = 'subrow';
561 subrowBox.appendChild(subrow); 567 subrowBox.appendChild(subrow);
562 568
563 for (var j = 0; j < properties.length; j++) 569 for (var j = 0; j < properties.length; j++)
564 subrow.appendChild(formatValue(data, properties[j])); 570 subrow.appendChild(formatValue(data, properties[j]));
565 571
566 var actionBox = document.createElement('div'); 572 var actionBox = document.createElement('div');
567 actionBox.className = 'actions'; 573 actionBox.className = 'actions';
568 subrowBox.appendChild(actionBox); 574 subrowBox.appendChild(actionBox);
569 575
570 if (!data.hasCustomInspectAction) { 576 if (data.isUiDevTools) {
577 addActionLink(row, 'inspect',
578 sendCommand.bind(null, 'inspect-ui', data.url), false);
579 } else if (!data.hasCustomInspectAction) {
571 addActionLink(row, 'inspect', sendTargetCommand.bind(null, 'inspect', data), 580 addActionLink(row, 'inspect', sendTargetCommand.bind(null, 'inspect', data),
572 data.hasNoUniqueId || data.adbAttachedForeign); 581 data.hasNoUniqueId || data.adbAttachedForeign);
573 } 582 }
574 583
575 list.appendChild(row); 584 list.appendChild(row);
576 return row; 585 return row;
577 } 586 }
578 587
579 function addActionLink(row, text, handler, opt_disabled) { 588 function addActionLink(row, text, handler, opt_disabled) {
580 var link = document.createElement('span'); 589 var link = document.createElement('span');
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
991 Array.prototype.forEach.call( 1000 Array.prototype.forEach.call(
992 deviceSection.querySelectorAll('.browser'), clearBrowserPorts); 1001 deviceSection.querySelectorAll('.browser'), clearBrowserPorts);
993 } 1002 }
994 1003
995 Array.prototype.forEach.call( 1004 Array.prototype.forEach.call(
996 document.querySelectorAll('.device'), clearPorts); 1005 document.querySelectorAll('.device'), clearPorts);
997 } 1006 }
998 1007
999 document.addEventListener('DOMContentLoaded', onload); 1008 document.addEventListener('DOMContentLoaded', onload);
1000 window.addEventListener('hashchange', onHashChange); 1009 window.addEventListener('hashchange', onHashChange);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698