Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 2502843002: DevTools: issue document.write(script) violation reports. (Closed)

Created:
4 years, 1 month ago by pfeldman
Modified:
4 years, 1 month ago
Reviewers:
caseq, dgozman, alph
CC:
chromium-reviews, caseq+blink_chromium.org, Nate Chapin, pfeldman+blink_chromium.org, tyoshino+watch_chromium.org, sof, eae+blinkwatch, Yoav Weiss, lushnikov+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org, loading-reviews_chromium.org, pfeldman, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: issue document.write(script) violation reports. BUG=662497 Committed: https://crrev.com/0c16b8a41265c5cbc7fbf1c6cfd0a6818e8c903b Cr-Commit-Position: refs/heads/master@{#432634}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments addressed #

Patch Set 3 : rebaselined #

Messages

Total messages: 23 (13 generated)
pfeldman
4 years, 1 month ago (2016-11-15 00:45:55 UTC) #2
alph
https://codereview.chromium.org/2502843002/diff/1/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp File third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp (right): https://codereview.chromium.org/2502843002/diff/1/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp#newcode70 third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:70: if (performanceMonitor) { early return plz https://codereview.chromium.org/2502843002/diff/1/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp#newcode223 third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp:223: if ...
4 years, 1 month ago (2016-11-15 00:56:22 UTC) #6
caseq
lgtm as soon as alph's comments are addressed
4 years, 1 month ago (2016-11-15 01:03:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502843002/20001
4 years, 1 month ago (2016-11-15 01:13:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-15 03:15:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502843002/20001
4 years, 1 month ago (2016-11-15 20:07:23 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/304661)
4 years, 1 month ago (2016-11-15 20:20:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502843002/40001
4 years, 1 month ago (2016-11-16 20:09:32 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-16 21:51:07 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-16 21:53:18 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0c16b8a41265c5cbc7fbf1c6cfd0a6818e8c903b
Cr-Commit-Position: refs/heads/master@{#432634}

Powered by Google App Engine
This is Rietveld 408576698