Don't early out recursion into PaintLayerChildren when computing composited bounds.

Don't early out recursion into PaintLayerChildren when computing composited bounds.

PaintLayer::boundingBoxForCompositing recursively computes the union of the
bounds of a root PaintLayer and its non-comositing descendants. Previously, in PaintLayer::boundingBoxForCompositing, there was code that would avoid recursing
into PaintLayer children if the PaintLayer was clipped. This is incorrect if there
are any PaintLayer descendants that have different clipping ancestors than
the current PaintLayer.

Also fixed a bug that transform-related properties were not considered containing
blocks for clipping of fixed-position children.

BUG=618046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/b33e49953078995f1cd28663a8a8b43012ac2eb0
Cr-Commit-Position: refs/heads/master@{#433232}

[chrishtr, 2016-11-14 23:39:26]

Description was changed from

==========
none

BUG=
==========

to

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-11-14 23:43:36]

Description was changed from

==========
none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't early out recursion into PaintLayerChildren when computing composited
bounds.

PaintLayer::boundingBoxForCompositing recursively computes the union of the
bounds of a root PaintLayer and its non-comositing descendants. Previously, in
PaintLayer::boundingBoxForCompositing, there was code that would avoid recursing
into PaintLayer children if the PaintLayer was clipped. This is incorrect if
there
are any PaintLayer descendants that have different clipping ancestors than
the current PaintLayer.

BUG=618046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-11-14 23:53:24]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-14 23:54:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 02:09:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 02:09:05]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2016-11-15 05:48:45]

Description was changed from

==========
Don't early out recursion into PaintLayerChildren when computing composited
bounds.

PaintLayer::boundingBoxForCompositing recursively computes the union of the
bounds of a root PaintLayer and its non-comositing descendants. Previously, in
PaintLayer::boundingBoxForCompositing, there was code that would avoid recursing
into PaintLayer children if the PaintLayer was clipped. This is incorrect if
there
are any PaintLayer descendants that have different clipping ancestors than
the current PaintLayer.

BUG=618046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't early out recursion into PaintLayerChildren when computing composited
bounds.

PaintLayer::boundingBoxForCompositing recursively computes the union of the
bounds of a root PaintLayer and its non-comositing descendants. Previously, in
PaintLayer::boundingBoxForCompositing, there was code that would avoid recursing
into PaintLayer children if the PaintLayer was clipped. This is incorrect if
there
are any PaintLayer descendants that have different clipping ancestors than
the current PaintLayer.

Also fixed a bug that transform-related properties were not considered
containing
blocks for clipping of fixed-position children.

BUG=618046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2016-11-15 05:48:50]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 05:49:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 06:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 06:37:16]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[chrishtr, 2016-11-16 18:38:00]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-16 18:38:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 22:38:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-16 22:38:08]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-11-16 22:41:56]

chrishtr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2016-11-16 22:50:47]

Should PaintLayer.cpp be in this CL?

[chrishtr, 2016-11-16 22:55:44]

On 2016/11/16 at 22:50:47, wangxianzhu wrote:
> Should PaintLayer.cpp be in this CL?

Indeed. Don't know how that got reverted in this patchset. Re-added.

[Xianzhu, 2016-11-16 22:58:46]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-11-16 22:58:46]

lgtm

[commit-bot: I haz the power, 2016-11-16 23:00:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 00:55:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 00:55:17]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2016-11-17 19:31:53]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-11-17 19:31:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2502833002/#ps100001
(title: "none")

[commit-bot: I haz the power, 2016-11-17 19:33:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 21:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:38:30]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[chrishtr, 2016-11-17 22:36:12]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-11-17 22:37:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 00:42:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:42:18]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[chrishtr, 2016-11-18 17:11:01]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2016-11-18 17:12:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 17:43:33]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-18 17:49:25]

Description was changed from

==========
Don't early out recursion into PaintLayerChildren when computing composited
bounds.

PaintLayer::boundingBoxForCompositing recursively computes the union of the
bounds of a root PaintLayer and its non-comositing descendants. Previously, in
PaintLayer::boundingBoxForCompositing, there was code that would avoid recursing
into PaintLayer children if the PaintLayer was clipped. This is incorrect if
there
are any PaintLayer descendants that have different clipping ancestors than
the current PaintLayer.

Also fixed a bug that transform-related properties were not considered
containing
blocks for clipping of fixed-position children.

BUG=618046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't early out recursion into PaintLayerChildren when computing composited
bounds.

PaintLayer::boundingBoxForCompositing recursively computes the union of the
bounds of a root PaintLayer and its non-comositing descendants. Previously, in
PaintLayer::boundingBoxForCompositing, there was code that would avoid recursing
into PaintLayer children if the PaintLayer was clipped. This is incorrect if
there
are any PaintLayer descendants that have different clipping ancestors than
the current PaintLayer.

Also fixed a bug that transform-related properties were not considered
containing
blocks for clipping of fixed-position children.

BUG=618046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/b33e49953078995f1cd28663a8a8b43012ac2eb0
Cr-Commit-Position: refs/heads/master@{#433232}
==========

[commit-bot: I haz the power, 2016-11-18 17:49:26]

Patchset 6 (id:??) landed as
https://crrev.com/b33e49953078995f1cd28663a8a8b43012ac2eb0
Cr-Commit-Position: refs/heads/master@{#433232}

[Matt Giuca, 2016-11-21 00:46:44]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2517863002/ by mgiuca@chromium.org.

The reason for reverting is: Speculative revert for https://crbug.com/667144.

A checkfail in PaintController.cpp started happening reliably in between r433228
and r433235. This CL looks closely related..