Restrict scope attribute on table cells

Restrict scope attribute on table cells

Restrict type attribute on table cells to known
values only as defined in [1].

BUG=666477
[1] https://html.spec.whatwg.org/#attr-th-scope

Committed: https://crrev.com/a2c8481e13d4dab8c61dfe28b63048f158b8b46f
Cr-Commit-Position: refs/heads/master@{#433208}

[rwlbuis, 2016-11-17 21:15:10]

Description was changed from

==========
menu WIP

BUG=
==========

to

==========
Restrict type attribute on menu

Restrict type attribute on menu to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=665000
==========

[rwlbuis, 2016-11-17 21:17:49]

Description was changed from

==========
Restrict type attribute on menu

Restrict type attribute on menu to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=665000
==========

to

==========
Restrict scope attribute on table cells

Restrict type attribute on menu to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=665000

[1]
==========

[rwlbuis, 2016-11-17 21:22:08]

Description was changed from

==========
Restrict scope attribute on table cells

Restrict type attribute on menu to known values only[1]:
"The attribute is an enumerated attribute with three keywords
and states. The "command" keyword maps to the Command state, the
"checkbox" keyword maps to the Checkbox state, and the "radio"
keyword maps to the Radio state. The missing value default
is the Command state."

BUG=665000

[1]
==========

to

==========
Restrict scope attribute on table cells

Restrict type attribute on menu to known values only as
defined in [1].

BUG=665000

[1] https://html.spec.whatwg.org/#attr-th-scope
==========

[rwlbuis, 2016-11-17 21:33:26]

Description was changed from

==========
Restrict scope attribute on table cells

Restrict type attribute on menu to known values only as
defined in [1].

BUG=665000

[1] https://html.spec.whatwg.org/#attr-th-scope
==========

to

==========
Restrict scope attribute on table cells

Restrict type attribute on menu to known values only as
defined in [1].

BUG=666477

[1] https://html.spec.whatwg.org/#attr-th-scope
==========

[rwlbuis, 2016-11-17 21:34:36]

Description was changed from

==========
Restrict scope attribute on table cells

Restrict type attribute on menu to known values only as
defined in [1].

BUG=666477

[1] https://html.spec.whatwg.org/#attr-th-scope
==========

to

==========
Restrict scope attribute on table cells

Restrict type attribute on metable cells to known
values only as defined in [1].

BUG=666477

[1] https://html.spec.whatwg.org/#attr-th-scope
==========

[rwlbuis, 2016-11-17 21:34:44]

Description was changed from

==========
Restrict scope attribute on table cells

Restrict type attribute on metable cells to known
values only as defined in [1].

BUG=666477

[1] https://html.spec.whatwg.org/#attr-th-scope
==========

to

==========
Restrict scope attribute on table cells

Restrict type attribute on table cells to known
values only as defined in [1].

BUG=666477

[1] https://html.spec.whatwg.org/#attr-th-scope
==========

[rwlbuis, 2016-11-17 21:35:14]

rob.buis@samsung.com changed reviewers:
+ tkent@chromium.org

[rwlbuis, 2016-11-17 21:35:14]

PTAL.

[tkent, 2016-11-17 21:59:18]

lgtm

https://codereview.chromium.org/2502803002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLTableCellElement.idl (right):

https://codereview.chromium.org/2502803002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLTableCellElement.idl:50: [CEReactions,
Reflect, ReflectOnly=("row","col", "rowgroup", "colgroup")] attribute DOMString
scope;
Add one space between |"row",| and |"col"|.

https://codereview.chromium.org/2502803002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/accessibility/AXTable.cpp (right):

https://codereview.chromium.org/2502803002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/accessibility/AXTable.cpp:236:
!cellElement.getAttribute(scopeAttr).isEmpty())
getAttribute -> fastGetAttribute

[rwlbuis, 2016-11-18 14:03:24]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-11-18 14:03:24]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2502803002/#ps20001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-11-18 14:03:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 15:48:55]

Description was changed from

==========
Restrict scope attribute on table cells

Restrict type attribute on table cells to known
values only as defined in [1].

BUG=666477

[1] https://html.spec.whatwg.org/#attr-th-scope
==========

to

==========
Restrict scope attribute on table cells

Restrict type attribute on table cells to known
values only as defined in [1].

BUG=666477

[1] https://html.spec.whatwg.org/#attr-th-scope
==========

[commit-bot: I haz the power, 2016-11-18 15:48:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-18 15:52:33]

Description was changed from

==========
Restrict scope attribute on table cells

Restrict type attribute on table cells to known
values only as defined in [1].

BUG=666477

[1] https://html.spec.whatwg.org/#attr-th-scope
==========

to

==========
Restrict scope attribute on table cells

Restrict type attribute on table cells to known
values only as defined in [1].

BUG=666477

[1] https://html.spec.whatwg.org/#attr-th-scope

Committed: https://crrev.com/a2c8481e13d4dab8c61dfe28b63048f158b8b46f
Cr-Commit-Position: refs/heads/master@{#433208}
==========

[commit-bot: I haz the power, 2016-11-18 15:52:35]

Patchset 2 (id:??) landed as
https://crrev.com/a2c8481e13d4dab8c61dfe28b63048f158b8b46f
Cr-Commit-Position: refs/heads/master@{#433208}