Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2502793002:
Fix a crash when AsyncTask cannot be scheduled while posting notification updates (Closed)
DescriptionFix a crash when AsyncTask cannot be scheduled while posting notification updates
When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail.
In that case, we should delay the updates to next update.
BUG=664928
Committed: https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c
Committed: https://crrev.com/fcd661af5f55fe1a58fdf8f12b8975bdd1f863c2
Cr-Original-Commit-Position: refs/heads/master@{#431934}
Cr-Commit-Position: refs/heads/master@{#432238}
Patch Set 1 #
Total comments: 2
Patch Set 2 : nit #Patch Set 3 : fix debug tests #Messages
Total messages: 19 (9 generated)
qinmin@chromium.org changed reviewers: + dfalcantara@chromium.org
PTAL
lgtm https://codereview.chromium.org/2502793002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java (right): https://codereview.chromium.org/2502793002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:688: for (int i = 0; i < progressPendingUpdate.size(); ++i) { Can this just go into the try section? You don't use success anywhere else, AFAICT.
https://codereview.chromium.org/2502793002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java (right): https://codereview.chromium.org/2502793002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java:688: for (int i = 0; i < progressPendingUpdate.size(); ++i) { On 2016/11/14 20:59:20, dfalcantara (check my queue) wrote: > Can this just go into the try section? You don't use success anywhere else, > AFAICT. Done.
The CQ bit was checked by qinmin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2502793002/#ps20001 (title: "nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix a crash when AsyncTask cannot be scheduled while posting notification updates When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail. In that case, we should delay the updates to next update. BUG=664928 ========== to ========== Fix a crash when AsyncTask cannot be scheduled while posting notification updates When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail. In that case, we should delay the updates to next update. BUG=664928 Committed: https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c Cr-Commit-Position: refs/heads/master@{#431934} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c Cr-Commit-Position: refs/heads/master@{#431934}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2500323002/ by horo@chromium.org. The reason for reverting is: Caused test failures. See http://crbug.com/665257 BUG=665257 .
Message was sent while issue was closed.
Description was changed from ========== Fix a crash when AsyncTask cannot be scheduled while posting notification updates When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail. In that case, we should delay the updates to next update. BUG=664928 Committed: https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c Cr-Commit-Position: refs/heads/master@{#431934} ========== to ========== Fix a crash when AsyncTask cannot be scheduled while posting notification updates When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail. In that case, we should delay the updates to next update. BUG=664928 Committed: https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c Cr-Commit-Position: refs/heads/master@{#431934} ==========
The CQ bit was checked by qinmin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2502793002/#ps40001 (title: "fix debug tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix a crash when AsyncTask cannot be scheduled while posting notification updates When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail. In that case, we should delay the updates to next update. BUG=664928 Committed: https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c Cr-Commit-Position: refs/heads/master@{#431934} ========== to ========== Fix a crash when AsyncTask cannot be scheduled while posting notification updates When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail. In that case, we should delay the updates to next update. BUG=664928 Committed: https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c Cr-Commit-Position: refs/heads/master@{#431934} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix a crash when AsyncTask cannot be scheduled while posting notification updates When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail. In that case, we should delay the updates to next update. BUG=664928 Committed: https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c Cr-Commit-Position: refs/heads/master@{#431934} ========== to ========== Fix a crash when AsyncTask cannot be scheduled while posting notification updates When posting notification updates, it is possible that chrome reaches the thread limit and AsyncTask will fail. In that case, we should delay the updates to next update. BUG=664928 Committed: https://crrev.com/120deee008d677fc7fd4a36d070681bbe380566c Committed: https://crrev.com/fcd661af5f55fe1a58fdf8f12b8975bdd1f863c2 Cr-Original-Commit-Position: refs/heads/master@{#431934} Cr-Commit-Position: refs/heads/master@{#432238} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/fcd661af5f55fe1a58fdf8f12b8975bdd1f863c2 Cr-Commit-Position: refs/heads/master@{#432238} |
