third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp - Issue 2502783004: Don't skip security checks for javascript: URLs when the JS stack is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

Issue 2502783004: Don't skip security checks for javascript: URLs when the JS stack is empty. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

index f9cb5ee6cdfe3cdde6310d1d929f7657aac149d7..a22c8d7a78ba26d4e081a0f6b4e64613feaf8e56 100644

--- a/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp

@@ -146,7 +146,7 @@ void HTMLIFrameElement::parseAttribute(const QualifiedName& name,

}

bool HTMLIFrameElement::layoutObjectIsNeeded(const ComputedStyle& style) {

- return isURLAllowed() && HTMLElement::layoutObjectIsNeeded(style);

+ return isURLAllowed(true) && HTMLElement::layoutObjectIsNeeded(style);

}

LayoutObject* HTMLIFrameElement::createLayoutObject(const ComputedStyle&) {