third_party/WebKit/Source/core/html/HTMLFrameElementBase.h - Issue 2502783004: Don't skip security checks for javascript: URLs when the JS stack is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

Issue 2502783004: Don't skip security checks for javascript: URLs when the JS stack is empty. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

diff --git a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

index ed03c0aa4bf5d683bcc8c1810218d421be2526ae..4b3937b1c2a3a24c33d36c9ad6f861f8d744a6c0 100644

--- a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

+++ b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

@@ -41,7 +41,7 @@ class CORE_EXPORT HTMLFrameElementBase : public HTMLFrameOwnerElement {

protected:

HTMLFrameElementBase(const QualifiedName&, Document&);

- bool isURLAllowed() const;

+ bool isURLAllowed(bool fromLayout = false) const;

void parseAttribute(const QualifiedName&,

const AtomicString&,