third_party/WebKit/Source/bindings/core/v8/ScriptController.h - Issue 2502783004: Don't skip security checks for javascript: URLs when the JS stack is empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptController.h

Issue 2502783004: Don't skip security checks for javascript: URLs when the JS stack is empty. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.h b/third_party/WebKit/Source/bindings/core/v8/ScriptController.h

index 301ace9bc21a34fd14a658e828301be4e732b014..eb78263f82ee8a4b869d68b3ae459d5123ce7927 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.h

@@ -124,8 +124,6 @@ class CORE_EXPORT ScriptController final

void enableEval();

void disableEval(const String& errorMessage);

- static bool canAccessFromCurrentOrigin(v8::Isolate*, Frame*);

void collectIsolatedContexts(

Vector<std::pair<ScriptState*, SecurityOrigin*>>&);