Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

Issue 2502783004: Don't skip security checks for javascript: URLs when the JS stack is empty. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 23 matching lines...) Expand all
34 bool canContainRangeEndPoint() const final { return false; } 34 bool canContainRangeEndPoint() const final { return false; }
35 35
36 // FrameOwner overrides: 36 // FrameOwner overrides:
37 ScrollbarMode scrollingMode() const override { return m_scrollingMode; } 37 ScrollbarMode scrollingMode() const override { return m_scrollingMode; }
38 int marginWidth() const override { return m_marginWidth; } 38 int marginWidth() const override { return m_marginWidth; }
39 int marginHeight() const override { return m_marginHeight; } 39 int marginHeight() const override { return m_marginHeight; }
40 40
41 protected: 41 protected:
42 HTMLFrameElementBase(const QualifiedName&, Document&); 42 HTMLFrameElementBase(const QualifiedName&, Document&);
43 43
44 bool isURLAllowed() const; 44 bool isURLAllowed(bool fromLayout = false) const;
45 45
46 void parseAttribute(const QualifiedName&, 46 void parseAttribute(const QualifiedName&,
47 const AtomicString&, 47 const AtomicString&,
48 const AtomicString&) override; 48 const AtomicString&) override;
49 InsertionNotificationRequest insertedInto(ContainerNode*) override; 49 InsertionNotificationRequest insertedInto(ContainerNode*) override;
50 void didNotifySubtreeInsertionsToDocument() final; 50 void didNotifySubtreeInsertionsToDocument() final;
51 void attachLayoutTree(const AttachContext& = AttachContext()) override; 51 void attachLayoutTree(const AttachContext& = AttachContext()) override;
52 52
53 // FIXME: Remove this method once we have input routing in the browser 53 // FIXME: Remove this method once we have input routing in the browser
54 // process. See http://crbug.com/339659. 54 // process. See http://crbug.com/339659.
(...skipping 29 matching lines...) Expand all
84 84
85 inline bool isHTMLFrameElementBase(const HTMLElement& element) { 85 inline bool isHTMLFrameElementBase(const HTMLElement& element) {
86 return isHTMLFrameElement(element) || isHTMLIFrameElement(element); 86 return isHTMLFrameElement(element) || isHTMLIFrameElement(element);
87 } 87 }
88 88
89 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFrameElementBase); 89 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFrameElementBase);
90 90
91 } // namespace blink 91 } // namespace blink
92 92
93 #endif // HTMLFrameElementBase_h 93 #endif // HTMLFrameElementBase_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698