Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 2502763004: INPUT element: Deprecate case-insensitive matching for radio button group names. (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years, 1 month ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

INPUT element: Deprecate case-insensitive matching for radio button group names. This CL doesn't use Deprecation::countDeprecation() because we'd like to show a deprecation warning message once per a pair of names. This CL introduces FrameConsole::addSingletonMesssage(). Intent: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/_p93QV64cFA/ZRAphH_9AgAJ BUG=658749 Committed: https://crrev.com/853295e62c2b9e035962c4f9cf871037d55c41b4 Cr-Commit-Position: refs/heads/master@{#432818}

Patch Set 1 #

Patch Set 2 : a #

Messages

Total messages: 22 (17 generated)
tkent
keishi@, would you review this please?
4 years, 1 month ago (2016-11-17 00:50:30 UTC) #16
keishi
LGTM
4 years, 1 month ago (2016-11-17 08:30:29 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502763004/40001
4 years, 1 month ago (2016-11-17 08:46:23 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-17 08:53:22 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 08:55:38 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/853295e62c2b9e035962c4f9cf871037d55c41b4
Cr-Commit-Position: refs/heads/master@{#432818}

Powered by Google App Engine
This is Rietveld 408576698