Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2502763003: Introduce ViewRoot to forward input/view events to native (Closed)
Patch Set: prevent view_root_ gc'ed Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 6f3295f7ccadb7617752f542d5a265cb274f7c28..d51e32f303eb6f4bf2248e4e6e07fc28bd275303 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -87,6 +87,9 @@ import java.util.Map;
* Provides a Java-side 'wrapper' around a WebContent (native) instance.
* Contains all the major functionality necessary to manage the lifecycle of a ContentView without
* being tied to the view system.
+ *
+ * WARNING: ContentViewCore is in the process of being broken up. Please do not add new stuff.
+ * See https://crbug.com/598880.
*/
@JNINamespace("content")
public class ContentViewCore implements AccessibilityStateChangeListener, DisplayAndroidObserver,
@@ -299,8 +302,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
// Size of the viewport in physical pixels as set from onSizeChanged.
private int mViewportWidthPix;
private int mViewportHeightPix;
- private int mPhysicalBackingWidthPix;
- private int mPhysicalBackingHeightPix;
private int mTopControlsHeightPix;
private int mBottomControlsHeightPix;
private boolean mTopControlsShrinkBlinkSize;
@@ -878,22 +879,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
}
/**
- * @return Width of underlying physical surface.
- */
- @CalledByNative
- private int getPhysicalBackingWidthPix() {
- return mPhysicalBackingWidthPix;
- }
-
- /**
- * @return Height of underlying physical surface.
- */
- @CalledByNative
- private int getPhysicalBackingHeightPix() {
- return mPhysicalBackingHeightPix;
- }
-
- /**
* @return The amount that the viewport size given to Blink is shrunk by the URL-bar..
*/
@CalledByNative
@@ -1437,21 +1422,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
updateAfterSizeChanged();
}
- /**
- * Called when the underlying surface the compositor draws to changes size.
- * This may be larger than the viewport size.
- */
- public void onPhysicalBackingSizeChanged(int wPix, int hPix) {
- if (mPhysicalBackingWidthPix == wPix && mPhysicalBackingHeightPix == hPix) return;
-
- mPhysicalBackingWidthPix = wPix;
- mPhysicalBackingHeightPix = hPix;
-
- if (mNativeContentViewCore != 0) {
- nativeWasResized(mNativeContentViewCore);
- }
- }
-
private void updateAfterSizeChanged() {
mPopupZoomer.hide(false);

Powered by Google App Engine
This is Rietveld 408576698