Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1241)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2502763003: Introduce ViewRoot to forward input/view events to native (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index de98a5b56485d5c4c62ed80b33ad02f70b3c0869..dc79c3497ebbce670fa2950f6e4d88447000f657 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -87,6 +87,9 @@ import java.util.Map;
* Provides a Java-side 'wrapper' around a WebContent (native) instance.
* Contains all the major functionality necessary to manage the lifecycle of a ContentView without
* being tied to the view system.
+ *
+ * WARNING: ContentViewCore is in the process of being broken up. Please do not add new stuff.
+ * See https://crbug.com/598880.
*/
@JNINamespace("content")
public class ContentViewCore implements AccessibilityStateChangeListener, DisplayAndroidObserver,
@@ -702,6 +705,16 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
}
/**
+ * @return {@link ViewAndroidDelegate} providing the interface for native
+ * layer for view-related events.
+ */
+ public ViewAndroidDelegate getViewDelegate() {
+ // TODO(jinsukkim): Remove this method once the view delegate instance becomes
+ // available directly from embedder.
+ return mViewAndroidDelegate;
+ }
+
+ /**
* Sets a new container view for this {@link ContentViewCore}.
*
* <p>WARNING: This method can also be used to replace the existing container view,
@@ -1487,21 +1500,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
updateAfterSizeChanged();
}
- /**
- * Called when the underlying surface the compositor draws to changes size.
- * This may be larger than the viewport size.
- */
- public void onPhysicalBackingSizeChanged(int wPix, int hPix) {
- if (mPhysicalBackingWidthPix == wPix && mPhysicalBackingHeightPix == hPix) return;
-
- mPhysicalBackingWidthPix = wPix;
- mPhysicalBackingHeightPix = hPix;
-
- if (mNativeContentViewCore != 0) {
- nativeWasResized(mNativeContentViewCore);
- }
- }
-
private void updateAfterSizeChanged() {
mPopupZoomer.hide(false);

Powered by Google App Engine
This is Rietveld 408576698