Introduce ViewRoot to forward input/view events to native

content/browser/web_contents/web_contents_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_view_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/logging.h"
 #include "cc/layers/layer.h"
@@ skipping 65 matching lines @@
   *render_view_host_delegate_view = rv;
   return rv;
 }
 
 WebContentsViewAndroid::WebContentsViewAndroid(
     WebContentsImpl* web_contents,
     WebContentsViewDelegate* delegate)
     : web_contents_(web_contents),
       content_view_core_(NULL),
       delegate_(delegate),
-      synchronous_compositor_client_(nullptr) {
-}
+      view_(this),
+      synchronous_compositor_client_(nullptr) {}
 
 WebContentsViewAndroid::~WebContentsViewAndroid() {
   if (view_.GetLayer())
     view_.GetLayer()->RemoveFromParent();
 }
 
 void WebContentsViewAndroid::SetContentViewCore(
     ContentViewCoreImpl* content_view_core) {
   content_view_core_ = content_view_core;
   RenderWidgetHostViewAndroid* rwhv = static_cast<RenderWidgetHostViewAndroid*>(
@@ skipping 132 matching lines @@
 
 void WebContentsViewAndroid::RenderViewCreated(RenderViewHost* host) {
 }
 
 void WebContentsViewAndroid::RenderViewSwappedIn(RenderViewHost* host) {
 }
 
 void WebContentsViewAndroid::SetOverscrollControllerEnabled(bool enabled) {
 }
 
+bool WebContentsViewAndroid::OnPhysicalBackingSizeChanged(int width,
+                                                          int height) {
+  // |SendScreenRects()| indirectly calls GetViewSize() that asks Java layer.
+  web_contents_->SendScreenRects();
+
+  RenderWidgetHostView* rwhv = !web_contents_->ShowingInterstitialPage() ?

[boliu, 2016/12/06 00:34:14]

it's not clear to me why WasResized should only called on the current RWHVA, but
not the "background" one, is there a precedence where the old code used to do
this?

eg is there code that updates the "background" RWHVA after the interstitial is
dismissed? WebContentsImpl::DidProceedOnInterstitial or DetachInterstitialPage
doesn't do this it seems


on the other hand, shouldn't each RWHVA get its own OnPhysicalBackingSizeChanged
implementation, and then can observe size updates?

[Jinsuk Kim, 2016/12/06 07:35:07]

I don't have good answers to your questions. You may be right in that each RWHVA
should get PBSC event but that's not what CVC was doing before this CL. It only
updates current RWHVA (either actual content or interstitial). 

[boliu, 2016/12/06 19:13:59]

afaict that's a bug in CVCImpl. Update both.

[Jinsuk Kim, 2016/12/07 12:36:28]

Done. I think the bug is addressed by letting each RWHVA observe physical
backing size update as in the updated patch.

+      web_contents_->GetRenderWidgetHostView() :
+      web_contents_->GetInterstitialPage()
+                    ->GetMainFrame()
+                    ->GetRenderViewHost()
+                    ->GetWidget()
+                    ->GetView();
+  (static_cast<RenderWidgetHostViewAndroid*>(rwhv))->WasResized();
+  return true;
+}
+
 void WebContentsViewAndroid::ShowContextMenu(
     RenderFrameHost* render_frame_host, const ContextMenuParams& params) {
   if (delegate_)
     delegate_->ShowContextMenu(render_frame_host, params);
 }
 
 void WebContentsViewAndroid::ShowPopupMenu(
     RenderFrameHost* render_frame_host,
     const gfx::Rect& bounds,
     int item_height,
@@ skipping 114 matching lines @@
 // This is called when we the renderer asks us to take focus back (i.e., it has
 // iterated past the last focusable element on the page).
 void WebContentsViewAndroid::TakeFocus(bool reverse) {
   if (web_contents_->GetDelegate() &&
       web_contents_->GetDelegate()->TakeFocus(web_contents_, reverse))
     return;
   web_contents_->GetRenderWidgetHostView()->Focus();
 }
 
 } // namespace content