Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/shapedetection/ShapeDetectionImpl.java

Issue 2502723002: ShapeDetection: implement barcode detection, blink part (Closed)
Patch Set: haraken@ comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/java/src/org/chromium/content/browser/shapedetection/ShapeDetectionImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/shapedetection/ShapeDetectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/shapedetection/ShapeDetectionImpl.java
index 328db0cb84592042ebf87f25e858c49f387375c7..6451c856de4d5dd3e78c68e2e2533e01b3b29979 100644
--- a/content/public/android/java/src/org/chromium/content/browser/shapedetection/ShapeDetectionImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/shapedetection/ShapeDetectionImpl.java
@@ -10,6 +10,7 @@ import android.media.FaceDetector;
import android.media.FaceDetector.Face;
import org.chromium.base.Log;
+import org.chromium.blink.mojom.BarcodeDetectionResult;
import org.chromium.blink.mojom.FaceDetectionResult;
import org.chromium.blink.mojom.ShapeDetection;
import org.chromium.gfx.mojom.RectF;
@@ -34,8 +35,8 @@ public class ShapeDetectionImpl implements ShapeDetection {
public ShapeDetectionImpl() {}
@Override
- public void detectFace(
- SharedBufferHandle frameData, int width, int height, DetectFaceResponse callback) {
+ public void detectFaces(
+ SharedBufferHandle frameData, int width, int height, DetectFacesResponse callback) {
if (!frameData.isValid()) {
Log.d(TAG, "Invalid sharedBufferHandle.");
return;
@@ -108,6 +109,13 @@ public class ShapeDetectionImpl implements ShapeDetection {
}
@Override
+ public void detectBarcodes(
+ SharedBufferHandle frameData, int width, int height, DetectBarcodesResponse callback) {
+ // TODO(mcasas): https://crbug.com/665150 implement this method.
+ callback.call(new BarcodeDetectionResult[0]);
+ }
+
+ @Override
public void close() {}
@Override
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698