 Chromium Code Reviews
 Chromium Code Reviews Issue 25027004:
  Add second argument to Future error handlers.  (Closed) 
  Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
    
  
    Issue 25027004:
  Add second argument to Future error handlers.  (Closed) 
  Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart| Index: sdk/lib/_internal/pub/lib/src/error_group.dart | 
| diff --git a/sdk/lib/_internal/pub/lib/src/error_group.dart b/sdk/lib/_internal/pub/lib/src/error_group.dart | 
| index 1130ef97e941a69fd3ab6056668a61b0129cc82e..8d73f84f00b28a69a314b9033af29ac29230b678 100644 | 
| --- a/sdk/lib/_internal/pub/lib/src/error_group.dart | 
| +++ b/sdk/lib/_internal/pub/lib/src/error_group.dart | 
| @@ -179,12 +179,12 @@ class _ErrorGroupFuture implements Future { | 
| _completer.future.catchError((_) {}); | 
| } | 
| - Future then(onValue(value), {onError(error)}) { | 
| + Future then(onValue(value), { Function onError }) { | 
| 
nweiz
2013/10/07 20:30:39
No spaces before "Function" or after "onError".
 
floitsch
2013/10/10 13:47:33
Done.
 
Lasse Reichstein Nielsen
2013/10/10 13:49:14
I actually prefer the spaces.
 
nweiz
2013/10/10 15:09:20
It's contrary to the style guide: "DON’T use a spa
 | 
| _hasListeners = true; | 
| return _completer.future.then(onValue, onError: onError); | 
| } | 
| - Future catchError(onError(error), {bool test(Object error)}) { | 
| + Future catchError(Function onError, {bool test(Object error)}) { | 
| _hasListeners = true; | 
| return _completer.future.catchError(onError, test: test); | 
| } |