Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2502643003: Revert of Adds eventlog provider dll to describe the message types of SYSLOG. (Closed)

Created:
4 years, 1 month ago by pdr.
Modified:
4 years, 1 month ago
Reviewers:
brettw, pastarmovj
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adds eventlog provider dll to describe the message types of SYSLOG. (patchset #2 id:20001 of https://codereview.chromium.org/2476353003/ ) Reason for revert: Caused windows compile errors: https://uberchromegw.corp.google.com/i/chromium/builders/Win/builds/49108/steps/steps/logs/stdio [1/1] LINK(DLL) eventlog_provider.dll eventlog_provider.dll.lib eventlog_provider.dll.pdb ninja explain: output eventlog_provider.dll.lib doesn't exist ninja explain: eventlog_provider.dll.lib is dirty Original issue's description: > Adds eventlog provider dll to describe the message types of SYSLOG. > > Creates a dll file that can be registered with the system event-logging > mechanisms on Windows to make the events generated when using the SYSLOG > macro nicer to read in the Event Viewer snapin. > > BUG=642115 > TEST=manual > > Committed: https://crrev.com/cee58011177e2cf4bb8cfd08e64b0cd48629b0ff > Cr-Commit-Position: refs/heads/master@{#431872} TBR=brettw@chromium.org,pastarmovj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=642115 Committed: https://crrev.com/145864aeae7cb83aefb0c645f23705f174a1850e Cr-Commit-Position: refs/heads/master@{#431875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -31 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/syslog_logging.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/win/BUILD.gn View 2 chunks +0 lines, -15 lines 0 comments Download
D base/win/eventlog_messages.mc View Binary file 0 comments Download
M chrome/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pdr.
Created Revert of Adds eventlog provider dll to describe the message types of SYSLOG.
4 years, 1 month ago (2016-11-14 18:14:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502643003/1
4 years, 1 month ago (2016-11-14 18:15:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 18:17:19 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 18:32:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/145864aeae7cb83aefb0c645f23705f174a1850e
Cr-Commit-Position: refs/heads/master@{#431875}

Powered by Google App Engine
This is Rietveld 408576698