Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2502633005: [Presentation API] check if frame() is null before accessing presentation.receiver attr (Closed)

Created:
4 years, 1 month ago by zhaobin
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presentation API] check if frame() is null before accessing presentation.receiver attr We have seen random crashes when accessing navigator.presentation.receiver attribute. We suspect that is caused by accessing attribute after frame() get destroyed. Add null check and only access frame() for the first time. BUG=657479 Committed: https://crrev.com/1399b5bdf21388b0b1a77c01473431988035e587 Cr-Commit-Position: refs/heads/master@{#432713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/presentation/Presentation.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
zhaobin
4 years, 1 month ago (2016-11-15 22:55:09 UTC) #2
haraken
LGTM
4 years, 1 month ago (2016-11-15 23:22:23 UTC) #3
mlamouri (slow - plz ping)
lgtm
4 years, 1 month ago (2016-11-16 18:59:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2502633005/1
4 years, 1 month ago (2016-11-17 01:43:03 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 02:41:21 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 02:50:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1399b5bdf21388b0b1a77c01473431988035e587
Cr-Commit-Position: refs/heads/master@{#432713}

Powered by Google App Engine
This is Rietveld 408576698